Page MenuHomePhorge
Differential D226

Add necessary features to Implement handle matrix uri in kazv
Needs ReviewPublic
Actions

Authored by nannanko on Sat, Aug 23, 6:44 AM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T29: Parse matrix links
Summary

Add roomId for CreateRoomResponse.

Add Client::addDirectRoom().

Type: add

Test Plan

verify unit tests pass.

Diff Detail

Repository
rL libkazv
Branch
nannanko/create-room-response
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 417
Build 817: GitLab CI for libkazv
Build 816: arc lint + arc unit

Event Timeline

nannanko created this revision.Sat, Aug 23, 6:44 AM
Owners added a reviewer: O1: the Kazv Project.Sat, Aug 23, 6:44 AM
Herald added a reviewer: servant. · View Herald TranscriptSat, Aug 23, 6:44 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster completed remote builds in B411: Diff 659.Sat, Aug 23, 7:16 AM
nannanko requested review of this revision.Sat, Aug 23, 7:16 AM
nannanko edited the summary of this revision. (Show Details)Sat, Aug 23, 11:06 AM
nannanko removed a reviewer: servant.
nannanko planned changes to this revision.Sat, Aug 23, 7:04 PM
nannanko updated this revision to Diff 665.Sat, Sep 6, 10:19 AM

Add addDirectRoom() function

nannanko planned changes to this revision.Sat, Sep 6, 10:21 AM
nannanko retitled this revision from Add data json for CreateRoomResponse to Add necessary features to Implement handle matrix uri in kazv.
nannanko edited the summary of this revision. (Show Details)

Tests has not been written yet.

nannanko mentioned this in D229: Handle matrix uri.Sat, Sep 6, 10:25 AM
nannanko added a task: T29: Parse matrix links.
nannanko updated this revision to Diff 667.Sat, Sep 6, 5:55 PM

Add tests

tusooa requested changes to this revision.Mon, Sep 8, 4:25 PM
tusooa added inline comments.
src/client/client.cpp
473–487

You should be reusing the content json of the original account data event, not directRoomMap(). directRoomMap is intended to be used as a way to quickly find which user a direct room is associated with. Your code here just convert things back and forth, and is inefficient and error-prone.

This revision now requires changes to proceed.Mon, Sep 8, 4:25 PM
nannanko updated this revision to Diff 673.Tue, Sep 9, 1:43 AM

Reusing the content json of the original account data event instead of directRoomMap()

nannanko marked an inline comment as done.Tue, Sep 9, 1:43 AM
Harbormaster failed remote builds in B420: Diff 673!Tue, Sep 9, 2:43 AM
nannanko updated this revision to Diff 675.Tue, Sep 9, 4:46 AM

Fixed tests for pipeline

Harbormaster completed remote builds in B422: Diff 675.Tue, Sep 9, 5:24 AM
nannanko updated this revision to Diff 676.Tue, Sep 9, 6:16 AM

Add comments of param for Client::addDirectRoom()

Harbormaster completed remote builds in B423: Diff 676.Tue, Sep 9, 6:52 AM

Revision Contents
Changeset List

Diff 667

View Options

src/client/actions/membership.cpp

Loading...
View Options

src/client/client.hpp

Loading...
View Options

src/client/client.cpp

Loading...
View Options

src/tests/client/account-data-test.cpp

Loading...
View Options

src/tests/client/create-room-test.cpp

Loading...