Handle matrix uri in kazv.(Includes Matrix URI scheme uri matrix.to navigation)
Require D226.
Type: add
Details
Details
- Reviewers
tusooa - Group Reviewers
O1: the Kazv Project - Maniphest Tasks
- T29: Parse matrix links
Verify unit tests pass.
Verify that kazv can handle matrix uri correctly. https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/2312-matrix-uri.md#operations-on-matrix-uris
Diff Detail
Diff Detail
- Repository
- rK kazv
- Branch
- nannanko/handle-matrix-uri
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 437 Build 857: GitLab CI for kazv Build 856: arc lint + arc unit
Event Timeline
Comment Actions
Please add a changelog type to the summary, using the following format:
Type: (add|remove|skip|security|fix)
| src/matrix-room-list.hpp | ||
|---|---|---|
| 48 | I think it's better called contains | |
| src/matrix-sdk.cpp | ||
| 464–473 | I think it's not the way to do it, because (as I mentioned earlier in another patch) directRoomMap contains the map from room id to user id. Since you want a map from user id to room ids, you should be using the m.direct account data directly. | |
| src/matrix-sdk.hpp | ||
| 104 | Use a meaningful name, and write in capitalized camel case. e.g. DirectRoomMap. | |
| 105 | Because of comments below, this might not be needed. LAGER_QT_READER is only needed if you need to access the property from qml. | |
Comment Actions
Use Client::accountData() instead of MatrixSdk::directRoomMap() in MatrixSdk::directRoomIds().
| src/contents/ui/event-types/TextTemplate.qml | ||
|---|---|---|
| 156–161 | The return only gets you out of the inner lambda (roomId) => { ... }, not the outer function. You might want to use for (roomId of matrixSdk.directRoomIds(userId)) { ... } instead. | |
| 185–186 | cannot handle alias | |
| src/tests/quick-tests/tst_MatrixLink.qml | ||
| 30 | does not conform to actual situation | |