Save as dialog will disappear if someone sends other messages, this diff fixed it.
Type: fix
Details
Details
- Reviewers
tusooa - Group Reviewers
O1: the Kazv Project - Maniphest Tasks
- T178: Save as dialog will disappear if someone sends other messages
- Open the Save As dialog
- Receive a new message from another user
- The dialog should no longer disappear
Diff Detail
Diff Detail
- Repository
- rK kazv
- Branch
- nannanko/filedialog-crash
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 630 Build 1242: Invoke Buildbot Buildbot build #1854 Build 1241: arc lint + arc unit
Event Timeline
Comment Actions
Please add a changelog type to the summary, using the following format:
Type: (add|remove|skip|security|fix)
| src/contents/ui/RoomPage.qml | ||
|---|---|---|
| 57 | This is O(N) in time complexity. First, do we really need to have the EventView? Is there a way to avoid having to use it? Second, even if we really need it, we can do a binary search to reduce the time complexity to O(logN). | |
| src/contents/ui/RoomTimelineView.qml | ||
| 189 | I am afraid this may not always return a meaningful value, as the requested event may not currently be displayed -- then there may not be an Item associated with this index (because of virtual scrolling) | |
| src/contents/ui/RoomTimelineView.qml | ||
|---|---|---|
| 189 | I know, but that's not a problem. Because a newly created event will automatically look for its KazvIOJob. Here we just need to find those events that have been created and notify them that the download has started. | |
| src/contents/ui/RoomPage.qml | ||
|---|---|---|
| 57 | As I replied in another comment, we only need to look for events within the visible range, so binary search is not needed either, I will modify here later | |
| src/contents/ui/EventView.qml | ||
|---|---|---|
| 43 | would downloadStarted be a better name? | |