Page MenuHomePhorge
Differential D304

Lift the save as dialog to the RoomPage to prevent ListView updates from destroying it
Changes PlannedPublicDraft
Actions

Authored by nannanko on Sat, May 23, 10:00 PM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T178: Save as dialog will disappear if someone sends other messages
Summary

Save as dialog will disappear if someone sends other messages, this diff fixed it.

Type: fix

Test Plan
  1. Open the Save As dialog
  2. Receive a new message from another user
  3. The dialog should no longer disappear

Diff Detail

Repository
rK kazv
Branch
nannanko/filedialog-crash
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 618
Build 1218: Invoke BuildbotBuildbot build #1760
Build 1217: arc lint + arc unit

Event Timeline

nannanko created this revision.Sat, May 23, 10:00 PM
Owners added a reviewer: O1: the Kazv Project.Sat, May 23, 10:00 PM
Herald added a reviewer: servant. · View Herald TranscriptSat, May 23, 10:00 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

nannanko added a task: T178: Save as dialog will disappear if someone sends other messages.Sat, May 23, 10:00 PM
nannanko edited the summary of this revision. (Show Details)
nannanko removed a reviewer: servant.
Harbormaster returned this revision to the author for changes because remote builds failed.Sat, May 23, 10:35 PM
Harbormaster failed remote builds in B618: Diff 950!

Revision Contents
Changeset List

PathSizePackages
src/
contents/
ui/
18 linesO1: the Kazv Project
35 linesO1: the Kazv Project

Diff 950

View Options

src/contents/ui/MediaFileMenu.qml

Loading...
View Options

src/contents/ui/RoomPage.qml

Loading...