Page MenuHomePhorge
Differential D100

Fix ItemDelegate display
ClosedPublic
Actions

Authored by tusooa on Jul 6 2024, 6:07 AM.
Tags
None
Referenced Files
F112772: D100.1732347455.diff
Thu, Nov 21, 11:37 PM
F112578: D100.1732337307.diff
Thu, Nov 21, 8:48 PM
F5679: image.png
Jul 6 2024, 6:11 AM
F5681: image.png
Jul 6 2024, 6:11 AM
F5677: image.png
Jul 6 2024, 6:11 AM
F5675: image.png
Jul 6 2024, 6:11 AM
F5671: image.png
Jul 6 2024, 6:11 AM
F5673: image.png
Jul 6 2024, 6:11 AM
View All 10 Files
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK9e0a99362330: Fix ItemDelegate display
Summary

The children of an ItemDelegate (or, a Control) needs to be in contentItem in order to be sized properly. This fixes the problem where it was not sized properly.

Type: fix

Test Plan

Test that read indicators, completion items and bubbles are sized properly.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Jul 6 2024, 6:07 AM
Owners added a reviewer: O1: the Kazv Project.Jul 6 2024, 6:07 AM
tusooa added a comment.Jul 6 2024, 6:11 AM
BeforeAfter
Completion
image.png (170×1 px, 22 KB)
image.png (170×1 px, 20 KB)
Read indicator
image.png (170×1 px, 40 KB)
image.png (170×1 px, 21 KB)
Read indicator popup
image.png (100×1 px, 21 KB)
image.png (124×1 px, 22 KB)
Bubble
image.png (89×1 px, 28 KB)
image.png (148×1 px, 28 KB)
Harbormaster completed remote builds in B144: Diff 240.Jul 6 2024, 6:17 AM
tusooa requested review of this revision.Jul 6 2024, 6:17 AM
nannanko accepted this revision.Jul 6 2024, 8:34 AM
This revision is now accepted and ready to land.Jul 6 2024, 8:34 AM
Closed by commit rK9e0a99362330: Fix ItemDelegate display. · Explain WhyJul 6 2024, 9:13 AM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK9e0a99362330: Fix ItemDelegate display.

Revision Contents
Changeset List

Diff 253

View Options

src/contents/ui/Bubble.qml

Loading...
View Options

src/contents/ui/Completion.qml

Loading...
View Options

src/contents/ui/EventReadIndicator.qml

Loading...
View Options

src/contents/ui/RoomTimelineView.qml

Loading...