Page MenuHomePhorge

Fix ItemDelegate display
ClosedPublic

Authored by tusooa on Jul 6 2024, 6:07 AM.
Tags
None
Referenced Files
F105712: D100.1730722795.diff
Sun, Nov 3, 4:19 AM
F5679: image.png
Jul 6 2024, 6:11 AM
F5681: image.png
Jul 6 2024, 6:11 AM
F5677: image.png
Jul 6 2024, 6:11 AM
F5675: image.png
Jul 6 2024, 6:11 AM
F5671: image.png
Jul 6 2024, 6:11 AM
F5673: image.png
Jul 6 2024, 6:11 AM
F5669: image.png
Jul 6 2024, 6:11 AM
Subscribers
None

Details

Summary

The children of an ItemDelegate (or, a Control) needs to be in contentItem in order to be sized properly. This fixes the problem where it was not sized properly.

Type: fix

Test Plan

Test that read indicators, completion items and bubbles are sized properly.

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 144
Build 277: GitLab CI for kazv
Build 276: arc lint + arc unit

Event Timeline

BeforeAfter
Completion
image.png (170×1 px, 22 KB)
image.png (170×1 px, 20 KB)
Read indicator
image.png (170×1 px, 40 KB)
image.png (170×1 px, 21 KB)
Read indicator popup
image.png (100×1 px, 21 KB)
image.png (124×1 px, 22 KB)
Bubble
image.png (89×1 px, 28 KB)
image.png (148×1 px, 28 KB)
tusooa requested review of this revision.Jul 6 2024, 6:17 AM
This revision is now accepted and ready to land.Jul 6 2024, 8:34 AM
This revision was automatically updated to reflect the committed changes.