Page MenuHomePhorge
Differential D100

Fix ItemDelegate display
ClosedPublic
Actions

Authored by tusooa on Jul 6 2024, 6:07 AM.
Tags
None
Referenced Files
F28603: D100.1726794017.diff
Wed, Sep 18, 6:00 PM
Unknown Object (File)
Mon, Sep 2, 2:30 PM
Unknown Object (File)
Fri, Aug 30, 9:30 AM
Unknown Object (File)
Fri, Aug 30, 9:30 AM
Unknown Object (File)
Fri, Aug 30, 9:30 AM
Unknown Object (File)
Tue, Aug 27, 8:27 PM
Unknown Object (File)
Mon, Aug 26, 9:13 PM
Unknown Object (File)
Sun, Aug 25, 8:12 PM
View All 67 Files
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK9e0a99362330: Fix ItemDelegate display
Summary

The children of an ItemDelegate (or, a Control) needs to be in contentItem in order to be sized properly. This fixes the problem where it was not sized properly.

Type: fix

Test Plan

Test that read indicators, completion items and bubbles are sized properly.

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 144
Build 277: GitLab CI for kazv
Build 276: arc lint + arc unit

Event Timeline

tusooa created this revision.Jul 6 2024, 6:07 AM
Owners added a reviewer: O1: the Kazv Project.Jul 6 2024, 6:07 AM
tusooa added a comment.Jul 6 2024, 6:11 AM
BeforeAfter
Completion
image.png (170×1 px, 22 KB)
image.png (170×1 px, 20 KB)
Read indicator
image.png (170×1 px, 40 KB)
image.png (170×1 px, 21 KB)
Read indicator popup
image.png (100×1 px, 21 KB)
image.png (124×1 px, 22 KB)
Bubble
image.png (89×1 px, 28 KB)
image.png (148×1 px, 28 KB)
Harbormaster completed remote builds in B144: Diff 240.Jul 6 2024, 6:17 AM
tusooa requested review of this revision.Jul 6 2024, 6:17 AM
nannanko accepted this revision.Jul 6 2024, 8:34 AM
This revision is now accepted and ready to land.Jul 6 2024, 8:34 AM
Closed by commit rK9e0a99362330: Fix ItemDelegate display. · Explain WhyJul 6 2024, 9:13 AM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK9e0a99362330: Fix ItemDelegate display.

Revision Contents
Changeset List

Diff 240

View Options

src/contents/ui/Bubble.qml

Loading...
View Options

src/contents/ui/Completion.qml

Loading...
View Options

src/contents/ui/EventReadIndicator.qml

Loading...
View Options

src/contents/ui/RoomTimelineView.qml

Loading...