Page MenuHomePhorge
Differential D123

Show favourite rooms at the top
ClosedPublic
Actions

Authored by nannanko on Jul 13 2024, 7:21 AM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T10: Pinned contacts
Commits
rK2ac7fb21ca0f: Show favourite rooms at the top
Summary

Matrix Spec points out the favourite room should be shown with higher precedence than other rooms. This revision implements it.

Type: add

Test Plan

Verify that the favourite rooms are displayed at the top.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nannanko created this revision.Jul 13 2024, 7:21 AM
Owners added a reviewer: O1: the Kazv Project.Jul 13 2024, 7:21 AM
Herald added a reviewer: servant. · View Herald TranscriptJul 13 2024, 7:21 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

nannanko added a task: T10: Pinned contacts.Jul 13 2024, 7:32 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 13 2024, 7:36 AM
Harbormaster failed remote builds in B173: Diff 292!
tusooa added a comment.Jul 13 2024, 7:59 AM

Add a unit test for this

src/matrix-room-list.cpp
117

Use count() not find()

119–121

Invitations should still be put on the very top

tusooa retitled this revision from Show favorite rooms at the top to Show favourite rooms at the top.Jul 13 2024, 8:01 AM
tusooa edited the summary of this revision. (Show Details)
tusooa edited the test plan for this revision. (Show Details)
tusooa removed a reviewer: servant.

Apparently you need to fix existing tests too.

nannanko updated this revision to Diff 308.Jul 13 2024, 7:11 PM
  • Fix tests for resent button
nannanko updated this revision to Diff 309.Jul 13 2024, 7:19 PM

Show favourite rooms at the top

nannanko updated this revision to Diff 311.Jul 13 2024, 7:22 PM

Show favourite rooms at the top

Harbormaster completed remote builds in B186: Diff 308.Jul 13 2024, 7:34 PM
Harbormaster completed remote builds in B187: Diff 309.Jul 13 2024, 7:44 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 13 2024, 7:55 PM
Harbormaster failed remote builds in B188: Diff 311!
nannanko added inline comments.Jul 17 2024, 8:14 AM
src/matrix-room-list.cpp
117

Why? The complexity of both of them is O(1).

nannanko updated this revision to Diff 324.Jul 17 2024, 8:27 AM

Put invitations the very top, use count() instead of find()

nannanko marked 2 inline comments as done.Jul 17 2024, 8:28 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 17 2024, 8:36 AM
Harbormaster failed remote builds in B200: Diff 324!
nannanko updated this revision to Diff 336.Jul 17 2024, 6:49 PM

Show favourite rooms at the top

Harbormaster completed remote builds in B205: Diff 336.Jul 17 2024, 6:59 PM
nannanko requested review of this revision.Jul 17 2024, 6:59 PM
tusooa added inline comments.Jul 17 2024, 7:43 PM
src/matrix-room-list.cpp
117

Because you don't need a pointer...

tusooa added a comment.Jul 17 2024, 7:45 PM

Add a test to confirm favourite rooms are above normal rooms and below invites

nannanko updated this revision to Diff 346.Jul 19 2024, 12:14 AM

Rebase onto servant

Harbormaster completed remote builds in B209: Diff 346.Jul 19 2024, 12:25 AM
nannanko updated this revision to Diff 347.Jul 19 2024, 1:47 AM
  • Add tests for room list priority
nannanko added a comment.Jul 19 2024, 1:47 AM
In D123#2379, @nannanko wrote:
  • Add tests for room list priority

Done.

Harbormaster completed remote builds in B210: Diff 347.Jul 19 2024, 1:57 AM
nannanko mentioned this in D125: Add confirm popup for delete event.Jul 19 2024, 1:58 AM
tusooa accepted this revision.Jul 19 2024, 2:39 PM
This revision is now accepted and ready to land.Jul 19 2024, 2:39 PM
Closed by commit rK2ac7fb21ca0f: Show favourite rooms at the top. · Explain WhyJul 20 2024, 6:48 PM
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rK2ac7fb21ca0f: Show favourite rooms at the top.

Revision Contents
Changeset List

Diff 362

View Options

src/matrix-room-list.cpp

Loading...
View Options

src/tests/matrix-room-list-test.cpp

Loading...