Page MenuHomePhorge

Show favourite rooms at the top
ClosedPublic

Authored by nannanko on Jul 13 2024, 7:21 AM.
Tags
None
Referenced Files
F39747: D123.1728623525.diff
Wed, Oct 9, 10:12 PM
F39712: D123.1728616299.diff
Wed, Oct 9, 8:11 PM
F39711: D123.1728616264.diff
Wed, Oct 9, 8:11 PM
F39710: D123.1728616248.diff
Wed, Oct 9, 8:10 PM
F39709: D123.1728616244.diff
Wed, Oct 9, 8:10 PM
F39708: D123.1728616213.diff
Wed, Oct 9, 8:10 PM
F39707: D123.1728616211.diff
Wed, Oct 9, 8:10 PM
F39706: D123.1728616197.diff
Wed, Oct 9, 8:09 PM
Subscribers
None

Details

Summary

Matrix Spec points out the favourite room should be shown with higher precedence than other rooms. This revision implements it.

Type: add

Test Plan

Verify that the favourite rooms are displayed at the top.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 13 2024, 7:36 AM
Harbormaster failed remote builds in B173: Diff 292!

Add a unit test for this

src/matrix-room-list.cpp
117

Use count() not find()

119–121

Invitations should still be put on the very top

tusooa retitled this revision from Show favorite rooms at the top to Show favourite rooms at the top.Jul 13 2024, 8:01 AM
tusooa edited the summary of this revision. (Show Details)
tusooa edited the test plan for this revision. (Show Details)
tusooa removed a reviewer: servant.

Apparently you need to fix existing tests too.

  • Fix tests for resent button

Show favourite rooms at the top

Show favourite rooms at the top

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 13 2024, 7:55 PM
Harbormaster failed remote builds in B188: Diff 311!
src/matrix-room-list.cpp
117

Why? The complexity of both of them is O(1).

Put invitations the very top, use count() instead of find()

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 17 2024, 8:36 AM
Harbormaster failed remote builds in B200: Diff 324!

Show favourite rooms at the top

src/matrix-room-list.cpp
117

Because you don't need a pointer...

Add a test to confirm favourite rooms are above normal rooms and below invites

  • Add tests for room list priority
In D123#2379, @nannanko wrote:
  • Add tests for room list priority

Done.

This revision is now accepted and ready to land.Jul 19 2024, 2:39 PM
This revision was automatically updated to reflect the committed changes.