Page MenuHomePhorge
Differential D317

Disable session locking on Android
ClosedPublic
Actions

Authored by tusooa on Sat, Jun 27, 11:11 AM.

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK5cf428d78275: Disable session locking on Android
Summary

Android does not yet have lockf. This makes it compile normally on Android.

Type: fix

CCBUG: https://iron.lily-is.land/T188

Test Plan

Verify this compiles on Android via Craft. You need to apply the patch at https://iron.lily-is.land/D318 to craft-blueprints-kde to build the necessary dependencies.

Diff Detail

Repository
rK kazv
Branch
servant
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 649
Build 1280: Invoke BuildbotBuildbot build #1931
Build 1279: arc lint + arc unit

Event Timeline

tusooa created this revision.Sat, Jun 27, 11:11 AM
Owners added a reviewer: O1: the Kazv Project.Sat, Jun 27, 11:11 AM
tusooa mentioned this in D318: Necessary changes to craft-blueprints-kde for kazv Android build.Sat, Jun 27, 11:14 AM
tusooa edited the test plan for this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Jun 27, 11:35 AM
Harbormaster failed remote builds in B649: Diff 992!
tusooa requested review of this revision.Sat, Jun 27, 6:55 PM
tusooa edited the summary of this revision. (Show Details)
tusooa edited the summary of this revision. (Show Details)Sat, Jun 27, 9:49 PM
nannanko accepted this revision.Sat, Jul 4, 7:44 PM
This revision is now accepted and ready to land.Sat, Jul 4, 7:44 PM
This revision was landed with ongoing or failed builds.Sat, Jul 4, 8:42 PM
Closed by commit rK5cf428d78275: Disable session locking on Android. · Explain Why
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK5cf428d78275: Disable session locking on Android.

Revision Contents
Changeset List

Diff 992

View Options

src/CMakeLists.txt

Loading...
View Options

src/kazv-platform.hpp.in

Loading...
View Options

src/kazv-session-lock-guard.cpp

Loading...