Differential D238

Use C++20 default comparisons
ClosedPublic
Actions

Authored by tusooa on Thu, Oct 2, 7:26 PM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rL1155e3e28668: Use C++20 default comparisons

Summary

This requires C++20 and uses the default comparisons where possible so we will no longer need to manually change the comparison operators when we add fields.

Type: add

Test Plan

Build kazv ( https://iron.lily-is.land/D240 ) against this. Verify everything works.

Diff Detail

Repository

rL libkazv

Branch

tusooa/cpp20

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 452
Build 887: GitLab CI for libkazv
Build 886: arc lint + arc unit

Event Timeline

tusooa created this revision.Thu, Oct 2, 7:26 PM

Owners added a reviewer: O1: the Kazv Project.Thu, Oct 2, 7:26 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Oct 2, 7:40 PM

Harbormaster failed remote builds in B452: Diff 709!

Fix discovery-test compilation

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Oct 3, 8:28 AM

Harbormaster failed remote builds in B453: Diff 710!

Fix pinned-events-test

Harbormaster completed remote builds in B454: Diff 711.Fri, Oct 3, 12:20 PM

tusooa requested review of this revision.Fri, Oct 3, 12:20 PM

kazv cannot be compiled with this diff.

In D238#4678, @nannanko wrote:

kazv cannot be compiled with this diff.

kazv can be compiled with c++20 in https://iron.lily-is.land/D240 together with this diff.

tusooa edited the test plan for this revision. (Show Details)Sun, Oct 5, 7:50 PM

nannanko accepted this revision.Sat, Oct 11, 7:40 PM

This revision is now accepted and ready to land.Sat, Oct 11, 7:40 PM

Closed by commit rL1155e3e28668: Use C++20 default comparisons. · Explain WhyMon, Oct 13, 5:43 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rL1155e3e28668: Use C++20 default comparisons.

Revision Contents
Changeset List

Path

Size

Packages

CMakeLists.txt

2 lines

O1: the Kazv Project

src/

base/

52 lines

18 lines

7 lines

2 lines

8 lines

13 lines

client/

actions/

2 lines

6 lines

device-list-tracker.hpp

5 lines

O1: the Kazv Project

device-list-tracker.cpp

14 lines

10 lines

room/

14 lines

63 lines

20 lines

crypto/

14 lines

inbound-group-session-p.hpp

13 lines

O1: the Kazv Project

tests/

client/

profile-test.cpp

4 lines

O1: the Kazv Project

crypto/

inbound-group-session-test.cpp

2 lines

O1: the Kazv Project

outbound-group-session-test.cpp

2 lines

O1: the Kazv Project

store-test.cpp

5 lines

O1: the Kazv Project

Diff 709

View Options

CMakeLists.txt

View Options

src/base/basejob.hpp

View Options

src/base/basejob.cpp

View Options

src/base/event.hpp

View Options

src/base/file-desc.hpp

View Options

src/base/file-desc.cpp

View Options

src/base/jsonwrap.hpp

View Options

src/client/actions/send.cpp

View Options

src/client/clientutil.hpp

View Options

src/client/device-list-tracker.hpp

View Options

src/client/device-list-tracker.cpp

View Options

src/client/encrypted-file.cpp

View Options

src/client/room/local-echo.hpp

View Options

src/client/room/room-model.hpp

View Options

src/client/room/room-model.cpp

View Options

src/crypto/crypto-util.hpp

View Options

src/crypto/inbound-group-session-p.hpp

View Options

src/tests/client/profile-test.cpp

View Options

src/tests/crypto/inbound-group-session-test.cpp

View Options

src/tests/crypto/outbound-group-session-test.cpp

View Options

Use C++20 default comparisonsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 709

CMakeLists.txt

src/base/basejob.hpp

src/base/basejob.cpp

src/base/event.hpp

src/base/file-desc.hpp

src/base/file-desc.cpp

src/base/jsonwrap.hpp

src/client/actions/send.cpp

src/client/clientutil.hpp

src/client/device-list-tracker.hpp

src/client/device-list-tracker.cpp

src/client/encrypted-file.cpp

src/client/room/local-echo.hpp

src/client/room/room-model.hpp

src/client/room/room-model.cpp

src/crypto/crypto-util.hpp

src/crypto/inbound-group-session-p.hpp

src/tests/client/profile-test.cpp

src/tests/crypto/inbound-group-session-test.cpp

src/tests/crypto/outbound-group-session-test.cpp

src/tests/store-test.cpp

Use C++20 default comparisons
ClosedPublic
Actions

Revision Contents
Changeset List