Paths

Table of Contentst

Differential D231

Fix potential ambiguous conversion from json to optional<json>
ClosedPublic
Actions

Authored by tusooa on Sep 16 2025, 5:37 AM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rL7e83b1477f89: Fix potential ambiguous conversion from json to optional<json>

Summary

Reported by @yifei:luv.asn.au on matrix. In some environments the compiler is not happy with return json(...); when the return type of the function is declared as std::optional<json>. This specifically invokes the std::optional constructor.

Type: fix

Test Plan

N/A

Diff Detail

Repository

rL libkazv

Branch

tusooa/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 427
Build 837: GitLab CI for libkazv
Build 836: arc lint + arc unit

Event Timeline

tusooa created this revision.Sep 16 2025, 5:37 AM

Owners added a reviewer: O1: the Kazv Project.Sep 16 2025, 5:37 AM

Harbormaster completed remote builds in B427: Diff 680.Sep 16 2025, 5:46 AM

tusooa requested review of this revision.Sep 16 2025, 5:46 AM

nannanko accepted this revision.Sep 17 2025, 5:07 PM

This revision is now accepted and ready to land.Sep 17 2025, 5:07 PM

Closed by commit rL7e83b1477f89: Fix potential ambiguous conversion from json to optional<json>. · Explain WhyMon, Sep 29, 5:58 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rL7e83b1477f89: Fix potential ambiguous conversion from json to optional<json>.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

base/

json-utils.hpp

2 lines

100%

O1: the Kazv Project

Diff 680

View Options

Fix potential ambiguous conversion from json to optional<json>ClosedPublicActions