Details

Reviewers

Group Reviewers

Commits

rKc03a083ac54d: Get rid of spin-wait Promises
rK4414aa46773c: Get rid of spin-wait Promises

Summary

We have introduced the signal trigger version of QtPromise in
d2a3732e. However, this is reverted in bdaba786 because it fails to
handle the case where the QtPromise is constructed in another thread than
the one where the executor runs. We introduce the signal trigger again
here and resolved the above problem by constructing it without a parent,
and then moving it into the thread of the executor.

This significantly reduces the CPU usage and CPU temperature on tusooa's computer.

Type: add

Test Plan

Verify that you can send out an encrypted message.

Diff Detail

Repository

rK kazv

Branch

tusooa/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24
Build 39: GitLab CI for kazv
Build 38: arc lint + arc unit

Event Timeline

tusooa created this revision.May 1 2024, 8:41 PM

Harbormaster returned this revision to the author for changes because remote builds failed.May 1 2024, 8:44 PM

Harbormaster failed remote builds in B23: Diff 32!

Remove changelog/ file

Use only relevant changes

Harbormaster failed remote builds in B24: Diff 33!May 1 2024, 8:51 PM

Harbormaster returned this revision to the author for changes because remote builds failed.May 1 2024, 8:53 PM

Harbormaster failed remote builds in B25: Diff 34!

This revision was not accepted when it landed; it landed in state Changes Planned.May 2 2024, 3:26 PM

This revision was landed with ongoing or failed builds.

Closed by commit rK4414aa46773c: Get rid of spin-wait Promises. · Explain Why

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rK4414aa46773c: Get rid of spin-wait Promises.

tusooa reopened this revision.May 3 2024, 3:47 PM

tusooa edited the summary of this revision. (Show Details)May 5 2024, 11:07 AM

Despite my lack of familiarity with the code in question, it was able to compile and test and perform well on tusooa's computer, which I believe makes it an excellent revision

This revision is now accepted and ready to land.May 10 2024, 2:02 AM

Closed by commit rKc03a083ac54d: Get rid of spin-wait Promises. · Explain WhyMay 10 2024, 7:29 AM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rKc03a083ac54d: Get rid of spin-wait Promises.

Owners added a reviewer: O1: the Kazv Project.May 10 2024, 7:29 AM

Get rid of spin-wait PromisesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33

.arcconfig

.gitlab-ci.yml

.gitlab/merge_request_templates/Default.md

changelogs/71.add

changelogs/84.add

src/CMakeLists.txt

src/contents/ui/AddStickerPopup.qml

src/contents/ui/Bubble.qml

src/contents/ui/EventReadIndicator.qml

src/contents/ui/EventView.qml

src/contents/ui/MainPage.qml

src/contents/ui/SendMessageBox.qml

src/contents/ui/StickerPicker.qml

src/contents/ui/event-types/Image.qml

src/contents/ui/event-types/MediaBubble.qml

src/l10n/cmn-Hans/100-ui.ftl

src/l10n/en/100-ui.ftl

src/main.cpp

src/matrix-event-reader-list-model.hpp

src/matrix-event-reader-list-model.cpp

src/matrix-event-reader.hpp

src/matrix-event-reader.cpp

src/matrix-event.hpp

src/matrix-event.cpp

src/matrix-room-list.hpp

src/matrix-room-list.cpp

src/matrix-room-timeline.cpp

src/matrix-room.hpp

src/matrix-room.cpp

src/matrix-sdk.hpp

src/matrix-sdk.cpp

src/matrix-sticker-pack-list.hpp

src/matrix-sticker-pack-list.cpp

src/matrix-sticker-pack-source.hpp

src/matrix-sticker-pack-source.cpp

src/matrix-sticker-pack.hpp

src/matrix-sticker-pack.cpp

src/matrix-sticker.hpp

src/matrix-sticker.cpp

src/meta-types.hpp

src/meta-types.cpp

src/qt-json.hpp

src/qt-promise-handler.hpp

src/qt-promise-handler.cpp

src/register-types.cpp

src/resources.qrc

src/tests/CMakeLists.txt

src/tests/matrix-room-list-test.cpp

src/tests/matrix-room-timeline-test.cpp

src/tests/matrix-sticker-pack-test.cpp

src/tests/qt-json-test.cpp

src/tests/qt-promise-handler-test.hpp

src/tests/qt-promise-handler-test.cpp

src/tests/quick-tests/tst_AddStickerPopup.qml

src/tests/quick-tests/tst_EventReadIndicator.qml

src/tests/quick-tests/tst_StickerPicker.qml

Get rid of spin-wait Promises
ClosedPublic
Actions

Revision Contents
Changeset List