Page MenuHomePhorge

Get rid of spin-wait Promises
ClosedPublic

Authored by tusooa on May 1 2024, 8:41 PM.
Tags
None
Referenced Files
F3303: D12.id32.diff
Mon, Jun 17, 7:02 PM
F3301: D12.id55.diff
Mon, Jun 17, 7:01 PM
F3298: D12.id38.diff
Mon, Jun 17, 6:59 PM
F3297: D12.id33.diff
Mon, Jun 17, 6:58 PM
F3296: D12.id34.diff
Mon, Jun 17, 6:58 PM
F3294: D12.id.diff
Mon, Jun 17, 6:57 PM
F3284: D12.diff
Mon, Jun 17, 6:49 PM
Unknown Object (File)
Mon, Jun 17, 4:50 PM
Subscribers
None

Details

Summary

We have introduced the signal trigger version of QtPromise in
d2a3732e. However, this is reverted in bdaba786 because it fails to
handle the case where the QtPromise is constructed in another thread than
the one where the executor runs. We introduce the signal trigger again
here and resolved the above problem by constructing it without a parent,
and then moving it into the thread of the executor.

This significantly reduces the CPU usage and CPU temperature on tusooa's computer.

Type: add

Test Plan

Verify that you can send out an encrypted message.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 1 2024, 8:44 PM
Harbormaster failed remote builds in B23: Diff 32!

Use only relevant changes

Harbormaster returned this revision to the author for changes because remote builds failed.May 1 2024, 8:53 PM
Harbormaster failed remote builds in B25: Diff 34!
This revision was not accepted when it landed; it landed in state Changes Planned.May 2 2024, 3:26 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

Despite my lack of familiarity with the code in question, it was able to compile and test and perform well on tusooa's computer, which I believe makes it an excellent revision

This revision is now accepted and ready to land.May 10 2024, 2:02 AM
This revision was automatically updated to reflect the committed changes.