Differential D11

Support filtering unnamed rooms by heros
ClosedPublic
Actions

Authored by tusooa on Apr 29 2024, 9:19 PM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rK5f172e341935: Support filtering unnamed rooms by heros
rK10f82d4656db: Support filtering unnamed rooms by heros

Summary

Direct chats or small group chats are often unnamed, and
for the case of kazv, this is the primary kind of use case we want
to support. This adds support to filter unnamed rooms by hero ids
or names.

Type: add

Test Plan

Input a part of a user's name into the filter text box. Verify that

it only shows unnamed rooms where room heroes contain that user.

Input a part of a user's matrix id into the filter text box. Verify that

it only shows unnamed rooms where room heroes contain that user.

Diff Detail

Repository

rK kazv

Branch

tusooa/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 22
Build 35: GitLab CI for kazv
Build 34: arc lint + arc unit

Event Timeline

tusooa created this revision.Apr 29 2024, 9:19 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 29 2024, 9:22 PM

Harbormaster failed remote builds in B22: Diff 31!

This revision was not accepted when it landed; it landed in state Changes Planned.May 2 2024, 3:26 PM

This revision was landed with ongoing or failed builds.

Closed by commit rK10f82d4656db: Support filtering unnamed rooms by heros. · Explain Why

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rK10f82d4656db: Support filtering unnamed rooms by heros.

tusooa reopened this revision.May 3 2024, 3:47 PM

Should this be modified to only apply matrix id matching when starting with '@'?

Because it would be counter-intuitive to just want to search for 'tusooa' and get all the users on that server in the friends list (or make this behavior a configurable option).

In D11#327, @nannanko wrote:

Should this be modified to only apply matrix id matching when starting with '@'?

Because it would be counter-intuitive to just want to search for 'tusooa' and get all the users on that server in the friends list (or make this behavior a configurable option).

I feel that's even more counter-intuitive

For reference, Element Web's filtering will also use Matrix id even if no @ is typed

nannanko accepted this revision.May 10 2024, 10:34 AM

This revision is now accepted and ready to land.May 10 2024, 10:34 AM

Closed by commit rK5f172e341935: Support filtering unnamed rooms by heros. · Explain WhyMay 10 2024, 3:22 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rK5f172e341935: Support filtering unnamed rooms by heros.

Owners added a reviewer: O1: the Kazv Project.May 10 2024, 3:22 PM