Page MenuHomePhorge

Support filtering unnamed rooms by heros
ClosedPublic

Authored by tusooa on Apr 29 2024, 9:19 PM.
Tags
None
Referenced Files
F3325: D11.id31.diff
Mon, Jun 17, 7:27 PM
F3324: D11.id36.diff
Mon, Jun 17, 7:27 PM
F3323: D11.id.diff
Mon, Jun 17, 7:27 PM
F3322: D11.id58.diff
Mon, Jun 17, 7:26 PM
F3290: D11.diff
Mon, Jun 17, 6:55 PM
Unknown Object (File)
Mon, Jun 17, 5:37 AM
Unknown Object (File)
Sun, Jun 16, 3:26 PM
Unknown Object (File)
Tue, Jun 11, 12:42 PM
Subscribers
None

Details

Summary

Direct chats or small group chats are often unnamed, and
for the case of kazv, this is the primary kind of use case we want
to support. This adds support to filter unnamed rooms by hero ids
or names.

Type: add

Test Plan
  1. Input a part of a user's name into the filter text box. Verify that

it only shows unnamed rooms where room heroes contain that user.

  1. Input a part of a user's matrix id into the filter text box. Verify that

it only shows unnamed rooms where room heroes contain that user.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 29 2024, 9:22 PM
Harbormaster failed remote builds in B22: Diff 31!
This revision was not accepted when it landed; it landed in state Changes Planned.May 2 2024, 3:26 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

Should this be modified to only apply matrix id matching when starting with '@'?

Because it would be counter-intuitive to just want to search for 'tusooa' and get all the users on that server in the friends list (or make this behavior a configurable option).

In D11#327, @nannanko wrote:

Should this be modified to only apply matrix id matching when starting with '@'?

Because it would be counter-intuitive to just want to search for 'tusooa' and get all the users on that server in the friends list (or make this behavior a configurable option).

I feel that's even more counter-intuitive

For reference, Element Web's filtering will also use Matrix id even if no @ is typed

This revision is now accepted and ready to land.May 10 2024, 10:34 AM