Use C++20 default comparisons
Needs ReviewPublic
Actions

Authored by tusooa on Thu, Oct 2, 7:26 PM.

Details

Reviewers

None

Group Reviewers

Summary

This requires C++20 and uses the default comparisons where possible so we will no longer need to manually change the comparison operators when we add fields.

Type: add

Test Plan

Build kazv ( https://iron.lily-is.land/D240 ) against this. Verify everything works.

Diff Detail

Repository

rL libkazv

Branch

tusooa/cpp20

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 454
Build 891: GitLab CI for libkazv
Build 890: arc lint + arc unit

Event Timeline

tusooa created this revision.Thu, Oct 2, 7:26 PM

Owners added a reviewer: O1: the Kazv Project.Thu, Oct 2, 7:26 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Oct 2, 7:40 PM

Harbormaster failed remote builds in B452: Diff 709!

Fix discovery-test compilation

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Oct 3, 8:28 AM

Harbormaster failed remote builds in B453: Diff 710!

Fix pinned-events-test

Harbormaster completed remote builds in B454: Diff 711.Fri, Oct 3, 12:20 PM

tusooa requested review of this revision.Fri, Oct 3, 12:20 PM

kazv cannot be compiled with this diff.

In D238#4678, @nannanko wrote:

kazv cannot be compiled with this diff.

kazv can be compiled with c++20 in https://iron.lily-is.land/D240 together with this diff.

tusooa edited the test plan for this revision. (Show Details)Sun, Oct 5, 7:50 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

CMakeLists.txt

2 lines

O1: the Kazv Project

src/

base/

basejob.hpp

52 lines

60%

O1: the Kazv Project

basejob.cpp

18 lines

61%

O1: the Kazv Project

event.hpp

7 lines

85%

O1: the Kazv Project

file-desc.hpp

2 lines

84%

O1: the Kazv Project

file-desc.cpp

8 lines

77%

O1: the Kazv Project

jsonwrap.hpp

13 lines

100%

O1: the Kazv Project

client/

actions/

send.cpp

2 lines

79%

O1: the Kazv Project

clientutil.hpp

6 lines

96%

O1: the Kazv Project

device-list-tracker.hpp

5 lines

58%

O1: the Kazv Project

device-list-tracker.cpp

14 lines

75%

O1: the Kazv Project

encrypted-file.cpp

10 lines

96%

O1: the Kazv Project

room/

local-echo.hpp

14 lines

95%

O1: the Kazv Project

room-model.hpp

63 lines

82%

O1: the Kazv Project

room-model.cpp

20 lines

94%

O1: the Kazv Project

crypto/

crypto-util.hpp

14 lines

100%

O1: the Kazv Project

inbound-group-session-p.hpp

13 lines

69%

O1: the Kazv Project

tests/

client/

2 lines

4 lines

room/

pinned-events-test.cpp

4 lines

O1: the Kazv Project

crypto/

inbound-group-session-test.cpp

2 lines

O1: the Kazv Project

outbound-group-session-test.cpp

2 lines

O1: the Kazv Project

store-test.cpp

5 lines

O1: the Kazv Project

Diff 711

View Options

CMakeLists.txt

View Options

src/base/basejob.hpp

View Options

src/base/basejob.cpp

View Options

src/base/event.hpp

View Options

src/base/file-desc.hpp

View Options

src/base/file-desc.cpp

View Options

src/base/jsonwrap.hpp

View Options

src/client/actions/send.cpp

View Options

src/client/clientutil.hpp

View Options

src/client/device-list-tracker.hpp

View Options

src/client/device-list-tracker.cpp

View Options

src/client/encrypted-file.cpp

View Options

src/client/room/local-echo.hpp

View Options

src/client/room/room-model.hpp

View Options

src/client/room/room-model.cpp

View Options

src/crypto/crypto-util.hpp

View Options

src/crypto/inbound-group-session-p.hpp

View Options

src/tests/client/discovery-test.cpp

View Options

src/tests/client/profile-test.cpp

View Options

src/tests/client/room/pinned-events-test.cpp

View Options

src/tests/crypto/inbound-group-session-test.cpp

View Options

src/tests/crypto/outbound-group-session-test.cpp

View Options

Use C++20 default comparisonsNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 711

CMakeLists.txt

src/base/basejob.hpp

src/base/basejob.cpp

src/base/event.hpp

src/base/file-desc.hpp

src/base/file-desc.cpp

src/base/jsonwrap.hpp

src/client/actions/send.cpp

src/client/clientutil.hpp

src/client/device-list-tracker.hpp

src/client/device-list-tracker.cpp

src/client/encrypted-file.cpp

src/client/room/local-echo.hpp

src/client/room/room-model.hpp

src/client/room/room-model.cpp

src/crypto/crypto-util.hpp

src/crypto/inbound-group-session-p.hpp

src/tests/client/discovery-test.cpp

src/tests/client/profile-test.cpp

src/tests/client/room/pinned-events-test.cpp

src/tests/crypto/inbound-group-session-test.cpp

src/tests/crypto/outbound-group-session-test.cpp

src/tests/store-test.cpp

Use C++20 default comparisons
Needs ReviewPublic
Actions

Revision Contents
Changeset List