Details

src/contents/ui/FileHandler.qml
33–35	To be future-proof, this should check if it contains any version starting at v1.11, until the release of a future version that does not have the authenticated v1 endpoint. By definition, if a server supports, say, v1.15, then it should also have the authenticated media v1 endpoint, even if it says it does not support v1.11 .
86–89
99–102	consider making it a property because it's reused
src/matrix-sdk.hpp
86–91	It's not clear what endpoint it is. The values are also confusing, because it makes people think v3 is newer than v1. I recommend naming them "UnauthenticatedMediaV3" and "AuthenticatedMediaV1." Also the enum name can be changed to "MediaDownloadEndpointVersion."

This revision now requires changes to proceed.Sat, Aug 16, 5:49 AM

tusooa edited the summary of this revision. (Show Details)Sat, Aug 16, 5:51 AM

tusooa edited the summary of this revision. (Show Details)

Improved naming, MatrixSdk::supportSpecVersion()

nannanko marked 4 inline comments as done.Sat, Aug 16, 3:11 PM

Harbormaster completed remote builds in B408: Diff 656.Sat, Aug 16, 3:44 PM

Harbormaster failed remote builds in B408: Diff 656!Sat, Aug 16, 3:58 PM

Harbormaster completed remote builds in B408: Diff 656.Sat, Aug 16, 6:54 PM

tusooa requested changes to this revision.Tue, Aug 19, 5:48 PM

tusooa added inline comments.

src/matrix-sdk.cpp
422	to transform this into an assertion on a range of two versions [a,b).

This revision now requires changes to proceed.Tue, Aug 19, 5:48 PM

Add MatrixSdk::checkSpecVersionRange() and tests

nannanko marked an inline comment as done.Sat, Aug 23, 5:37 AM

Harbormaster failed remote builds in B410: Diff 658!Sat, Aug 23, 5:58 AM

tusooa added inline comments.Sat, Aug 23, 4:28 PM

src/matrix-sdk.hpp
113	Use exact wording to represent which of the limits are inclusive or exclusive. Based on your representation, it seems that your implementation is inclusive on both ends. In that case, say `[minVer, maxVer]`.

Improvement comments

Harbormaster completed remote builds in B412: Diff 660.Sat, Aug 23, 6:18 PM

nannanko marked an inline comment as done.Sat, Aug 23, 7:02 PM

tusooa accepted this revision.Sat, Aug 23, 7:02 PM

This revision is now accepted and ready to land.Sat, Aug 23, 7:02 PM

Closed by commit rK00916a6f4814: Add fallback endpoint for download. · Explain WhySat, Aug 23, 10:37 PM

This revision was automatically updated to reflect the committed changes.

nannanko added a commit: rK00916a6f4814: Add fallback endpoint for download.

Add fallback endpoint for download
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 658

src/contents/ui/FileHandler.qml

src/contents/ui/Main.qml

src/kazv-io-job.hpp

src/kazv-io-job.cpp

src/kazv-io-manager.hpp

src/kazv-io-manager.cpp

src/matrix-sdk.hpp

src/matrix-sdk.cpp

src/tests/kazv-io-job-test.cpp

src/tests/matrix-sdk-test.cpp

src/tests/quick-tests/test-helpers/KazvIOManagerMock.qml

src/tests/quick-tests/test-helpers/MatrixSdkMock.qml

src/tests/quick-tests/tst_FileHandler.qml

Add fallback endpoint for downloadClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 658

src/contents/ui/FileHandler.qml

src/contents/ui/Main.qml

src/kazv-io-job.hpp

src/kazv-io-job.cpp

src/kazv-io-manager.hpp

src/kazv-io-manager.cpp

src/matrix-sdk.hpp

src/matrix-sdk.cpp

src/tests/kazv-io-job-test.cpp

src/tests/matrix-sdk-test.cpp

src/tests/quick-tests/test-helpers/KazvIOManagerMock.qml

src/tests/quick-tests/test-helpers/MatrixSdkMock.qml

src/tests/quick-tests/tst_FileHandler.qml

Add fallback endpoint for download
ClosedPublic
Actions

Revision Contents
Changeset List