Details

Reviewers

tusooa

Group Reviewers

O1: the Kazv Project

Maniphest Tasks

T164: Cannot download file from matrix.org

Summary

When the old Endpoint cannot be downloaded, fall back to the new endpoint.

Requires D216

Type: add

Test Plan

Log in to a matrix.org account (or other homeservers that do not support old endpoints), check the download function work fine.

Verify unit tests pass.

Diff Detail

Repository

rK kazv

Branch

nannanko/mxc-v1

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 406
Build 795: GitLab CI for kazv
Build 794: arc lint + arc unit

Event Timeline

nannanko created this revision.May 26 2025, 10:14 PM

Owners added a reviewer: O1: the Kazv Project.May 26 2025, 10:14 PM

nannanko added a parent revision: D216: Add GetContentJobV1 for the new download endpoint that needs authorization.May 26 2025, 10:15 PM

Harbormaster returned this revision to the author for changes because remote builds failed.May 26 2025, 10:21 PM

Harbormaster failed remote builds in B373: Diff 608!

Add unit test

nannanko edited the test plan for this revision. (Show Details)May 26 2025, 10:51 PM

nannanko edited the test plan for this revision. (Show Details)

Harbormaster returned this revision to the author for changes because remote builds failed.May 26 2025, 10:57 PM

Harbormaster failed remote builds in B374: Diff 609!

nannanko added a task: T164: Cannot download file from matrix.org.May 28 2025, 1:40 AM

nannanko edited the summary of this revision. (Show Details)May 28 2025, 6:06 PM

Perfer new endpoint

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 7 2025, 6:07 PM

Harbormaster failed remote builds in B382: Diff 620!

Automatically select the download endpoint according to the server version

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 14 2025, 6:54 PM

Harbormaster failed remote builds in B387: Diff 627!

Add tests

nannanko published this revision for review.Jun 24 2025, 9:48 PM

nannanko planned changes to this revision.

Harbormaster failed remote builds in B393: Diff 635!Jun 24 2025, 11:15 PM

nannanko requested review of this revision.Jun 28 2025, 7:01 PM

Rebase to servant

Harbormaster failed remote builds in B400: Diff 644!Jul 5 2025, 6:38 PM

nannanko planned changes to this revision.Jul 5 2025, 7:18 PM

Fixed CI

Harbormaster failed remote builds in B401: Diff 646!Jul 5 2025, 8:06 PM

nannanko planned changes to this revision.Jul 5 2025, 8:28 PM

Fixed tests.

Harbormaster failed remote builds in B406: Diff 653!Sat, Aug 9, 10:10 AM

Fixed qt quick tests

Harbormaster completed remote builds in B407: Diff 654.Sat, Aug 9, 10:50 AM

Add fallback endpoint for download
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 653

src/contents/ui/FileHandler.qml

src/contents/ui/Main.qml

src/kazv-io-job.hpp

src/kazv-io-job.cpp

src/kazv-io-manager.hpp

src/kazv-io-manager.cpp

src/matrix-sdk.hpp

src/matrix-sdk.cpp

src/tests/kazv-io-job-test.cpp

src/tests/quick-tests/test-helpers/KazvIOManagerMock.qml

src/tests/quick-tests/test-helpers/MatrixSdkMock.qml

src/tests/quick-tests/tst_FileHandler.qml

Add fallback endpoint for downloadNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 653

src/contents/ui/FileHandler.qml

src/contents/ui/Main.qml

src/kazv-io-job.hpp

src/kazv-io-job.cpp

src/kazv-io-manager.hpp

src/kazv-io-manager.cpp

src/matrix-sdk.hpp

src/matrix-sdk.cpp

src/tests/kazv-io-job-test.cpp

src/tests/quick-tests/test-helpers/KazvIOManagerMock.qml

src/tests/quick-tests/test-helpers/MatrixSdkMock.qml

src/tests/quick-tests/tst_FileHandler.qml

Add fallback endpoint for download
Needs ReviewPublic
Actions

Revision Contents
Changeset List