Page MenuHomePhorge
Differential D217

Add fallback endpoint for download
Needs ReviewPublic
Actions

Authored by nannanko on May 26 2025, 10:14 PM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T164: Cannot download file from matrix.org
Summary

When the old Endpoint cannot be downloaded, fall back to the new endpoint.

Requires D216

Type: add

Test Plan

Log in to a matrix.org account (or other homeservers that do not support old endpoints), check the download function work fine.

Verify unit tests pass.

Diff Detail

Repository
rK kazv
Branch
nannanko/mxc-v1
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 393
Build 769: GitLab CI for kazv
Build 768: arc lint + arc unit

Event Timeline

nannanko created this revision.May 26 2025, 10:14 PM
Owners added a reviewer: O1: the Kazv Project.May 26 2025, 10:14 PM
nannanko added a parent revision: D216: Add GetContentJobV1 for the new download endpoint that needs authorization.May 26 2025, 10:15 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 26 2025, 10:21 PM
Harbormaster failed remote builds in B373: Diff 608!
nannanko updated this revision to Diff 609.May 26 2025, 10:50 PM

Add unit test

nannanko edited the test plan for this revision. (Show Details)May 26 2025, 10:51 PM
nannanko edited the test plan for this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.May 26 2025, 10:57 PM
Harbormaster failed remote builds in B374: Diff 609!
nannanko added a task: T164: Cannot download file from matrix.org.May 28 2025, 1:40 AM
nannanko edited the summary of this revision. (Show Details)May 28 2025, 6:06 PM
nannanko updated this revision to Diff 620.Sat, Jun 7, 6:00 PM

Perfer new endpoint

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Jun 7, 6:07 PM
Harbormaster failed remote builds in B382: Diff 620!
nannanko updated this revision to Diff 627.Sat, Jun 14, 6:47 PM

Automatically select the download endpoint according to the server version

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Jun 14, 6:54 PM
Harbormaster failed remote builds in B387: Diff 627!
nannanko updated this revision to Diff 635.Tue, Jun 24, 9:47 PM

Add tests

nannanko published this revision for review.Tue, Jun 24, 9:48 PM
nannanko planned changes to this revision.
Harbormaster failed remote builds in B393: Diff 635!Tue, Jun 24, 11:15 PM
nannanko requested review of this revision.Sat, Jun 28, 7:01 PM

Revision Contents
Changeset List

Diff 635

View Options

src/contents/ui/FileHandler.qml

Loading...
View Options

src/kazv-io-job.hpp

Loading...
View Options

src/kazv-io-job.cpp

Loading...
View Options

src/kazv-io-manager.hpp

Loading...
View Options

src/kazv-io-manager.cpp

Loading...
View Options

src/matrix-sdk.hpp

Loading...
View Options

src/matrix-sdk.cpp

Loading...
View Options

src/tests/kazv-io-job-test.cpp

Loading...
View Options

src/tests/quick-tests/test-helpers/KazvIOManagerMock.qml

Loading...
View Options

src/tests/quick-tests/test-helpers/MatrixSdkMock.qml

Loading...
View Options

src/tests/quick-tests/tst_FileHandler.qml

Loading...