Page MenuHomePhorge
Differential D221

Use safetar in place of rsync for archiving
ClosedPublic
Actions

Authored by tusooa on Tue, Jun 24, 6:43 PM.

Details

Reviewers
None
Group Reviewers
O2: lilybuild
Commits
rBd0f5b65447d0: Use safetar in place of rsync for archiving
Summary

Previously we first rsync then collect the artifact archive. This causes triple disk usage. We now use safetar instead. It also prevents the archive to symlink outside the result directory, and supports excluding files.

Type: add

Test Plan

Verify the pipeline passes on my blog and the test-buildbot repo.

Diff Detail

Repository
rB lilybuild
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 390
Build 763: Invoke BuildbotBuildbot build #189
Build 762: arc lint + arc unit

Event Timeline

tusooa created this revision.Tue, Jun 24, 6:43 PM
Owners added a reviewer: O2: lilybuild.Tue, Jun 24, 6:43 PM
Herald added a reviewer: servant. · View Herald TranscriptTue, Jun 24, 6:43 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jun 24, 6:48 PM
Harbormaster failed remote builds in B390: Diff 632!
tusooa edited the summary of this revision. (Show Details)Thu, Jun 26, 5:27 AM
tusooa removed a reviewer: servant.
tusooa updated this revision to Diff 637.Thu, Jun 26, 8:50 PM

Separate master and worker tests

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Jun 26, 8:51 PM
Harbormaster failed remote builds in B395: Diff 637!
tusooa updated this revision to Diff 638.Thu, Jun 26, 9:11 PM

Backport py3.13 glob.translate

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Jun 26, 9:12 PM
Harbormaster failed remote builds in B396: Diff 638!
tusooa updated this revision to Diff 639.Thu, Jun 26, 9:18 PM

Add fnmatch._translate backport

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Jun 26, 9:20 PM
Harbormaster failed remote builds in B397: Diff 639!
tusooa updated this revision to Diff 640.Thu, Jun 26, 9:22 PM

Fix clone arcanist

Harbormaster completed remote builds in B398: Diff 640.Thu, Jun 26, 9:24 PM
tusooa requested review of this revision.Thu, Jun 26, 9:24 PM
tusooa added a comment.Fri, Jun 27, 4:07 PM

Tested to work on b.lily-is.land .

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jun 27, 5:39 PM
Closed by commit rBd0f5b65447d0: Use safetar in place of rsync for archiving. · Explain Why
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rBd0f5b65447d0: Use safetar in place of rsync for archiving.

Revision Contents
Changeset List

PathSizePackages
lilybuild/
lilybuild/
55 linesO2: lilybuild
108 linesO2: lilybuild
tests/
208 linesO2: lilybuild

Diff 632

View Options

lilybuild/lilybuild/ci_steps.py

Loading...
View Options

lilybuild/lilybuild/safetar.py

Loading...
View Options

lilybuild/lilybuild/tests/safetar_test.py

Loading...