It checks whether the server supports the authenticated media endpoint. If it does, use it. Otherwise, use the old endpoint.
Type: add
Details
Details
- Reviewers
tusooa - Group Reviewers
O1: the Kazv Project - Maniphest Tasks
- T164: Cannot download file from matrix.org
- Commits
- rK00916a6f4814: Add fallback endpoint for download
Log in to a matrix.org account (or other homeservers that do not support old endpoints), check the download function work fine.
Verify unit tests pass.
Diff Detail
Diff Detail
- Repository
- rK kazv
- Branch
- nannanko/mxc-v1
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 387 Build 757: GitLab CI for kazv Build 756: arc lint + arc unit
Event Timeline
| src/contents/ui/FileHandler.qml | ||
|---|---|---|
| 33–35 | To be future-proof, this should check if it contains any version starting at v1.11, until the release of a future version that does not have the authenticated v1 endpoint. | |
| 85–88 | ||
| 102–105 | consider making it a property because it's reused | |
| src/matrix-sdk.hpp | ||
| 86–91 | It's not clear what endpoint it is. The values are also confusing, because it makes people think v3 is newer than v1. I recommend naming them "UnauthenticatedMediaV3" and "AuthenticatedMediaV1." Also the enum name can be changed to "MediaDownloadEndpointVersion." | |
| src/matrix-sdk.cpp | ||
|---|---|---|
| 421 | to transform this into an assertion on a range of two versions [a,b). | |
| src/matrix-sdk.hpp | ||
|---|---|---|
| 112 | Use exact wording to represent which of the limits are inclusive or exclusive. Based on your representation, it seems that your implementation is inclusive on both ends. In that case, say [minVer, maxVer]. | |