Page MenuHomePhorge
Differential D189

Use a temp file to save session
ClosedPublic
Actions

Authored by tusooa on Oct 13 2024, 7:29 PM.
Tags
None
Referenced Files
F112280: D189.1732288083.diff
Thu, Nov 21, 7:08 AM
F112251: D189.1732285170.diff
Thu, Nov 21, 6:19 AM
F112232: D189.1732283711.diff
Thu, Nov 21, 5:55 AM
F112231: D189.1732283617.diff
Thu, Nov 21, 5:53 AM
F112157: D189.1732272275.diff
Thu, Nov 21, 2:44 AM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rKc3a37a47cb61: Use a temp file to save session
Summary

To avoid losing data when saving session, we write to a temp file first, and then move it into place.

Type: add

BUG: https://iron.lily-is.land/T143

Test Plan

Verify unit tests pass. Open kazv and verify it can save data properly.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Oct 13 2024, 7:29 PM
Owners added a reviewer: O1: the Kazv Project.Oct 13 2024, 7:29 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 13 2024, 7:44 PM
Harbormaster failed remote builds in B297: Diff 496!
tusooa updated this revision to Diff 497.Oct 14 2024, 8:47 AM

Use an unprivileged user to build and test

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 14 2024, 8:51 AM
Harbormaster failed remote builds in B298: Diff 497!
tusooa updated this revision to Diff 498.Oct 14 2024, 9:03 AM

Fix calling build-unprivileged.sh

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 14 2024, 9:16 AM
Harbormaster failed remote builds in B299: Diff 498!
tusooa updated this revision to Diff 499.Oct 14 2024, 10:03 AM

Change to build dir ahead of time

tusooa updated this revision to Diff 500.Oct 14 2024, 10:24 AM

Fix release build

Harbormaster failed remote builds in B300: Diff 499!Oct 14 2024, 10:31 AM
Harbormaster completed remote builds in B301: Diff 500.Oct 14 2024, 10:41 AM
tusooa requested review of this revision.Oct 14 2024, 10:41 AM
nannanko accepted this revision.Oct 16 2024, 6:13 AM
This revision is now accepted and ready to land.Oct 16 2024, 6:13 AM
Closed by commit rKc3a37a47cb61: Use a temp file to save session. · Explain WhyOct 16 2024, 3:25 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rKc3a37a47cb61: Use a temp file to save session.

Revision Contents
Changeset List

Diff 503

View Options

packaging/GNU-Linux/appimage/build-unprivileged.sh

Loading...
View Options

packaging/GNU-Linux/appimage/build.sh

Loading...
View Options

src/matrix-sdk.hpp

Loading...
View Options

src/matrix-sdk.cpp

Loading...
View Options

src/tests/matrix-sdk-sessions-test.hpp

Loading...
View Options

src/tests/matrix-sdk-sessions-test.cpp

Loading...