Page MenuHomePhorge
Differential D189

Use a temp file to save session
ClosedPublic
Actions

Authored by tusooa on Oct 13 2024, 7:29 PM.

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rKc3a37a47cb61: Use a temp file to save session
Summary

To avoid losing data when saving session, we write to a temp file first, and then move it into place.

Type: add

BUG: https://iron.lily-is.land/T143

Test Plan

Verify unit tests pass. Open kazv and verify it can save data properly.

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 298
Build 584: GitLab CI for kazv
Build 583: arc lint + arc unit

Event Timeline

tusooa created this revision.Oct 13 2024, 7:29 PM
Owners added a reviewer: O1: the Kazv Project.Oct 13 2024, 7:29 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 13 2024, 7:44 PM
Harbormaster failed remote builds in B297: Diff 496!
tusooa updated this revision to Diff 497.Oct 14 2024, 8:47 AM

Use an unprivileged user to build and test

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 14 2024, 8:51 AM
Harbormaster failed remote builds in B298: Diff 497!
tusooa updated this revision to Diff 498.Oct 14 2024, 9:03 AM

Fix calling build-unprivileged.sh

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 14 2024, 9:16 AM
Harbormaster failed remote builds in B299: Diff 498!
tusooa updated this revision to Diff 499.Oct 14 2024, 10:03 AM

Change to build dir ahead of time

tusooa updated this revision to Diff 500.Oct 14 2024, 10:24 AM

Fix release build

Harbormaster failed remote builds in B300: Diff 499!Oct 14 2024, 10:31 AM
Harbormaster completed remote builds in B301: Diff 500.Oct 14 2024, 10:41 AM
tusooa requested review of this revision.Oct 14 2024, 10:41 AM
nannanko accepted this revision.Oct 16 2024, 6:13 AM
This revision is now accepted and ready to land.Oct 16 2024, 6:13 AM
Closed by commit rKc3a37a47cb61: Use a temp file to save session. · Explain WhyOct 16 2024, 3:25 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rKc3a37a47cb61: Use a temp file to save session.

Revision Contents
Changeset List

Diff 497

View Options

packaging/GNU-Linux/appimage/build-unprivileged.sh

Loading...
View Options

packaging/GNU-Linux/appimage/build.sh

Loading...
View Options

src/matrix-sdk.hpp

Loading...
View Options

src/matrix-sdk.cpp

Loading...
View Options

src/tests/matrix-sdk-sessions-test.hpp

Loading...
View Options

src/tests/matrix-sdk-sessions-test.cpp

Loading...