src/tests/kazv-file-test.cpp
32–35	don't write anything with side effects into the assertion macros. your code should still work if you remove all of the macros entirely.
36	use Qt's random generator

nannanko planned changes to this revision.Aug 24 2024, 6:04 PM

Add tests for KazvFile and KazvSaveFile

nannanko marked 2 inline comments as done.Aug 24 2024, 6:56 PM

Harbormaster completed remote builds in B282: Diff 469.Aug 24 2024, 7:07 PM

test that if it is cancelled, the file will not be found on disk.

This revision now requires changes to proceed.Aug 27 2024, 7:04 PM

In D176#3265, @tusooa wrote:

test that if it is cancelled, the file will not be found on disk.

This seems not necessary to test, or should be placed in the test of KazvIOJob, because the relevant functions are implemented by Qt. If you think it is necessary, I will write relevant tests for KazvIOBaseJob::cancel().

nannanko requested review of this revision.Aug 31 2024, 6:28 AM

tusooa accepted this revision.Aug 31 2024, 7:03 PM

This revision is now accepted and ready to land.Aug 31 2024, 7:03 PM

Closed by commit rKd9db047e9339: Add tests for KazvFile and KazvSaveFile. · Explain WhySep 4 2024, 12:46 AM

This revision was automatically updated to reflect the committed changes.

nannanko added a commit: rKd9db047e9339: Add tests for KazvFile and KazvSaveFile.