Page MenuHomePhorge

Add tests for KazvFile and KazvSaveFile
ClosedPublic

Authored by nannanko on Aug 23 2024, 10:39 PM.

Details

Summary

Add test for KazvFile and KazvSaveFile.

Type: add

Test Plan

Verify unit tests pass.

Diff Detail

Repository
rK kazv
Branch
nannanko/kazv-file-test
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 282
Build 552: GitLab CI for kazv
Build 551: arc lint + arc unit

Event Timeline

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 23 2024, 10:54 PM
Harbormaster failed remote builds in B279: Diff 466!
nannanko edited the summary of this revision. (Show Details)
nannanko removed a reviewer: servant.
src/tests/kazv-file-test.cpp
32–35

don't write anything with side effects into the assertion macros. your code should still work if you remove all of the macros entirely.

36

use Qt's random generator

Add tests for KazvFile and KazvSaveFile

tusooa requested changes to this revision.Aug 27 2024, 7:04 PM

test that if it is cancelled, the file will not be found on disk.

This revision now requires changes to proceed.Aug 27 2024, 7:04 PM
In D176#3265, @tusooa wrote:

test that if it is cancelled, the file will not be found on disk.

This seems not necessary to test, or should be placed in the test of KazvIOJob, because the relevant functions are implemented by Qt. If you think it is necessary, I will write relevant tests for KazvIOBaseJob::cancel().

This revision is now accepted and ready to land.Aug 31 2024, 7:03 PM