Page MenuHomePhorge
Differential D176

Add tests for KazvFile and KazvSaveFile
ClosedPublic
Actions

Authored by nannanko on Fri, Aug 23, 10:39 PM.
Tags
None
Referenced Files
F27031: D176.1726598897.diff
Mon, Sep 16, 11:48 AM
Unknown Object (File)
Sat, Sep 14, 8:26 PM
Unknown Object (File)
Sat, Sep 14, 6:54 PM
Unknown Object (File)
Sat, Sep 14, 6:46 AM
Unknown Object (File)
Thu, Sep 12, 10:18 AM
Unknown Object (File)
Tue, Sep 10, 11:37 PM
Unknown Object (File)
Mon, Sep 9, 9:48 PM
Unknown Object (File)
Mon, Sep 9, 8:55 PM
View All 43 Files
Subscribers
None

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Commits
rKd9db047e9339: Add tests for KazvFile and KazvSaveFile
Summary

Add test for KazvFile and KazvSaveFile.

Type: add

Test Plan

Verify unit tests pass.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nannanko created this revision.Fri, Aug 23, 10:39 PM
Owners added a reviewer: O1: the Kazv Project.Fri, Aug 23, 10:39 PM
Herald added a reviewer: servant. · View Herald TranscriptFri, Aug 23, 10:39 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Aug 23, 10:54 PM
Harbormaster failed remote builds in B279: Diff 466!
nannanko requested review of this revision.Fri, Aug 23, 11:16 PM
nannanko edited the summary of this revision. (Show Details)
nannanko removed a reviewer: servant.
Harbormaster completed remote builds in B279: Diff 466.Fri, Aug 23, 11:32 PM
tusooa added inline comments.Sat, Aug 24, 5:54 PM
src/tests/kazv-file-test.cpp
32–35

don't write anything with side effects into the assertion macros. your code should still work if you remove all of the macros entirely.

36

use Qt's random generator

nannanko planned changes to this revision.Sat, Aug 24, 6:04 PM
nannanko updated this revision to Diff 469.Sat, Aug 24, 6:51 PM

Add tests for KazvFile and KazvSaveFile

nannanko marked 2 inline comments as done.Sat, Aug 24, 6:56 PM
Harbormaster completed remote builds in B282: Diff 469.Sat, Aug 24, 7:07 PM
tusooa requested changes to this revision.Tue, Aug 27, 7:04 PM

test that if it is cancelled, the file will not be found on disk.

This revision now requires changes to proceed.Tue, Aug 27, 7:04 PM
nannanko added a comment.EditedSat, Aug 31, 6:28 AM
In D176#3265, @tusooa wrote:

test that if it is cancelled, the file will not be found on disk.

This seems not necessary to test, or should be placed in the test of KazvIOJob, because the relevant functions are implemented by Qt. If you think it is necessary, I will write relevant tests for KazvIOBaseJob::cancel().

nannanko requested review of this revision.Sat, Aug 31, 6:28 AM
tusooa accepted this revision.Sat, Aug 31, 7:03 PM
This revision is now accepted and ready to land.Sat, Aug 31, 7:03 PM
Closed by commit rKd9db047e9339: Add tests for KazvFile and KazvSaveFile. · Explain WhyWed, Sep 4, 12:46 AM
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rKd9db047e9339: Add tests for KazvFile and KazvSaveFile.

Revision Contents
Changeset List

Diff 474

View Options

src/tests/CMakeLists.txt

Loading...
View Options

src/tests/kazv-file-test.cpp

Loading...