Differential D288

Make SendMessageBox Scrollable and limited in height
ClosedPublic
Actions

Authored by Yucheng on Sat, Feb 21, 7:19 PM.

Details

Reviewers

None

Group Reviewers

O1: the Kazv Project

Commits

rK5e7bbf14890a: Make SendMessageBox Scrollable and limited in height

Summary

Make SendMessageBox Scrollable and limited in height

Type: fix

Test Plan

Enter a text with multiple (>= 10) lines and observe that the textbox expand until a maximum height is reached and the textbox is scrollable

Diff Detail

Repository

rK kazv

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Yucheng created this revision.Sat, Feb 21, 7:19 PM

Owners added a reviewer: O1: the Kazv Project.Sat, Feb 21, 7:19 PM

Replace 150 by Kirigami.Units.gridUnit * 8

otherwise looks good

src/contents/ui/SendMessageBox.qml
115

Harbormaster completed remote builds in B550: Diff 856.Sat, Feb 21, 8:27 PM

Harbormaster completed remote builds in B551: Diff 857.Sat, Feb 21, 8:54 PM

Yucheng requested review of this revision.Sat, Feb 21, 8:54 PM

Change code style

Harbormaster completed remote builds in B552: Diff 859.Thu, Feb 26, 1:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Feb 26, 8:08 PM

Closed by commit rK5e7bbf14890a: Make SendMessageBox Scrollable and limited in height. · Explain Why

This revision was automatically updated to reflect the committed changes.

Yucheng added a commit: rK5e7bbf14890a: Make SendMessageBox Scrollable and limited in height.

Revision Contents
Changeset List

Path

Size

Packages

src/

contents/

ui/

SendMessageBox.qml

245 lines

O1: the Kazv Project

Diff 861

View Options

src/contents/ui/SendMessageBox.qml

Make SendMessageBox Scrollable and limited in heightClosedPublicActions