Page MenuHomePhorge

Create an overlay page type and change several pages to overlay
AcceptedPublic

Authored by Yucheng on Wed, Feb 18, 4:27 PM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Summary

Change room settings and several pages in the drawer to overlay to avoid problems of closing pages

Type: fix

CCBUG: https://iron.lily-is.land/T171

Test Plan

Open the pages affected, interact and use the back button provided by the header and observe that the page closed correctly.

Diff Detail

Repository
rK kazv
Branch
yucheng
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 549
Build 1080: Invoke BuildbotBuildbot build #1211
Build 1079: arc lint + arc unit

Event Timeline

nannanko added inline comments.
src/contents/ui/ClosableScrollableOverlay.qml
11

There should be a newline at the end of the file.

Added a newline at end of file. Fix the bug of not able to switch to main when restore session.

This revision is now accepted and ready to land.Sat, Feb 21, 6:45 PM