Page MenuHomePhorge
Differential D284

Create an overlay page type and change several pages to overlay
ClosedPublic
Actions

Authored by Yucheng on Wed, Feb 18, 4:27 PM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Commits
rK46027855d219: Create an overlay page type and change several pages to overlay
Summary

Change room settings and several pages in the drawer to overlay to avoid problems of closing pages

Type: fix

CCBUG: https://iron.lily-is.land/T171

Test Plan

Open the pages affected, interact and use the back button provided by the header and observe that the page closed correctly.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Yucheng created this revision.Wed, Feb 18, 4:27 PM
Owners added a reviewer: O1: the Kazv Project.Wed, Feb 18, 4:27 PM
Harbormaster completed remote builds in B545: Diff 847.Wed, Feb 18, 5:09 PM
Yucheng requested review of this revision.Wed, Feb 18, 5:09 PM
tusooa mentioned this in D286: Implement Single Sign On.Fri, Feb 20, 7:13 AM
nannanko subscribed.Sat, Feb 21, 5:02 AM
nannanko added inline comments.
src/contents/ui/ClosableScrollableOverlay.qml
11

There should be a newline at the end of the file.

tusooa edited the summary of this revision. (Show Details)Sat, Feb 21, 12:00 PM
Yucheng updated this revision to Diff 855.Sat, Feb 21, 6:44 PM

Added a newline at end of file. Fix the bug of not able to switch to main when restore session.

tusooa accepted this revision.Sat, Feb 21, 6:45 PM
This revision is now accepted and ready to land.Sat, Feb 21, 6:45 PM
Harbormaster completed remote builds in B549: Diff 855.Sat, Feb 21, 8:01 PM
Closed by commit rK46027855d219: Create an overlay page type and change several pages to overlay. · Explain WhyThu, Feb 26, 8:08 PM
This revision was automatically updated to reflect the committed changes.
Yucheng added a commit: rK46027855d219: Create an overlay page type and change several pages to overlay.
tusooa mentioned this in rK7bf9481b8ada: Implement Single Sign On.Wed, Mar 11, 8:43 PM

Revision Contents
Changeset List

Diff 860

View Options

src/CMakeLists.txt

Loading...
View Options

src/contents/ui/ActionSettingsPage.qml

Loading...
View Options

src/contents/ui/ClosableScrollableOverlay.qml

Loading...
View Options

src/contents/ui/CreateRoomPage.qml

Loading...
View Options

src/contents/ui/JoinRoomPage.qml

Loading...
View Options

src/contents/ui/Main.qml

Loading...
View Options

src/contents/ui/SettingsPage.qml

Loading...
View Options

src/contents/ui/UserPage.qml

Loading...
View Options

src/contents/ui/room-settings/RoomInvitePage.qml

Loading...
View Options

src/contents/ui/room-settings/RoomMemberListPage.qml

Loading...
View Options

src/contents/ui/room-settings/RoomSettingsPage.qml

Loading...
View Options

src/contents/ui/room-settings/RoomStatePage.qml

Loading...
View Options

src/contents/ui/room-settings/RoomStickerPacksPage.qml

Loading...