Page MenuHomePhorge
Differential D200

Disable show KIO status notification when cache files
ClosedPublic
Actions

Authored by nannanko on Nov 10 2024, 1:42 AM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Commits
rKdb800e30cd4e: Disable show KIO status notification when cache files
Summary

Show KIO status notification only when the user manually download something.

Type: fix

Test Plan
  1. Open a room containing files that need to be cached.
  1. Wait for a while and check that the files are cached and displayed correctly (e.g. images and avatars).

Unit tests will be added along with T114.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nannanko created this revision.Nov 10 2024, 1:42 AM
Owners added a reviewer: O1: the Kazv Project.Nov 10 2024, 1:42 AM
Herald added a reviewer: servant. · View Herald TranscriptNov 10 2024, 1:42 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster completed remote builds in B323: Diff 537.Nov 10 2024, 2:43 AM
nannanko requested review of this revision.Nov 10 2024, 2:43 AM
tusooa edited the summary of this revision. (Show Details)Nov 11 2024, 10:11 AM
tusooa removed a reviewer: servant.
tusooa requested changes to this revision.Nov 12 2024, 5:04 PM

When you need to use a boolean constant as an argument, almost always use a comment to indicate what exactly it is referring to (unless it is very clear by the function name).

src/kazv-io-manager.cpp
86
101
118
121
This revision now requires changes to proceed.Nov 12 2024, 5:04 PM
nannanko updated this revision to Diff 539.Nov 15 2024, 6:05 AM
nannanko marked 4 inline comments as done.

Add comment for boolean arguments

Harbormaster completed remote builds in B325: Diff 539.Nov 15 2024, 6:18 AM
tusooa accepted this revision.Nov 15 2024, 3:58 PM
This revision is now accepted and ready to land.Nov 15 2024, 3:58 PM
Closed by commit rKdb800e30cd4e: Disable show KIO status notification when cache files. · Explain WhyNov 16 2024, 12:00 AM
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rKdb800e30cd4e: Disable show KIO status notification when cache files.

Revision Contents
Changeset List

Diff 542

View Options

src/kazv-io-job.hpp

Loading...
View Options

src/kazv-io-job.cpp

Loading...
View Options

src/kazv-io-manager.hpp

Loading...
View Options

src/kazv-io-manager.cpp

Loading...