Page MenuHomePhorge
Differential D200

Disable show KIO status notification when cache files
Needs RevisionPublic
Actions

Authored by nannanko on Sun, Nov 10, 1:42 AM.
Tags
None
Referenced Files
F110824: D200.1731728947.diff
Thu, Nov 14, 7:49 PM
F110823: D200.1731728424.diff
Thu, Nov 14, 7:40 PM
F110768: D200.1731662839.diff
Thu, Nov 14, 1:27 AM
F110766: D200.1731659682.diff
Thu, Nov 14, 12:34 AM
Subscribers
None

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Summary

Show KIO status notification only when the user manually download something.

Type: fix

Test Plan
  1. Open a room containing files that need to be cached.
  1. Wait for a while and check that the files are cached and displayed correctly (e.g. images and avatars).

Unit tests will be added along with T114.

Diff Detail

Repository
rK kazv
Branch
nannanko/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 323
Build 634: GitLab CI for kazv
Build 633: arc lint + arc unit

Event Timeline

nannanko created this revision.Sun, Nov 10, 1:42 AM
Owners added a reviewer: O1: the Kazv Project.Sun, Nov 10, 1:42 AM
Herald added a reviewer: servant. · View Herald TranscriptSun, Nov 10, 1:42 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster completed remote builds in B323: Diff 537.Sun, Nov 10, 2:43 AM
nannanko requested review of this revision.Sun, Nov 10, 2:43 AM
tusooa edited the summary of this revision. (Show Details)Mon, Nov 11, 10:11 AM
tusooa removed a reviewer: servant.
tusooa requested changes to this revision.Tue, Nov 12, 5:04 PM

When you need to use a boolean constant as an argument, almost always use a comment to indicate what exactly it is referring to (unless it is very clear by the function name).

src/kazv-io-manager.cpp
86
100
117
120
This revision now requires changes to proceed.Tue, Nov 12, 5:04 PM

Revision Contents
Changeset List

Diff 537

View Options

src/kazv-io-job.hpp

Loading...
View Options

src/kazv-io-job.cpp

Loading...
View Options

src/kazv-io-manager.hpp

Loading...
View Options

src/kazv-io-manager.cpp

Loading...