Differential D148

Make encrypted videos playable
ClosedPublic
Actions

Authored by tusooa on Jul 25 2024, 3:02 PM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Maniphest Tasks

T124: Video doesn't really work

Commits

rK5f05cc674ae6: Make encrypted videos playable

Summary

This reuses FileHandler in Video, and thus makes it work with encrypted videos.

Type: fix

Test Plan

Verify that you can play encrypted videos.

Diff Detail

Repository

rK kazv

Branch

tusooa/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 225
Build 439: GitLab CI for kazv
Build 438: arc lint + arc unit

Event Timeline

tusooa created this revision.Jul 25 2024, 3:02 PM

Owners added a reviewer: O1: the Kazv Project.Jul 25 2024, 3:02 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2024, 3:04 PM

Harbormaster failed remote builds in B225: Diff 381!

tusooa added a task: T124: Video doesn't really work.Jul 25 2024, 9:06 PM

Harbormaster completed remote builds in B225: Diff 381.Jul 26 2024, 1:49 PM

tusooa requested review of this revision.Jul 26 2024, 1:49 PM

nannanko accepted this revision.Aug 3 2024, 7:49 AM

This revision is now accepted and ready to land.Aug 3 2024, 7:49 AM

Closed by commit rK5f05cc674ae6: Make encrypted videos playable. · Explain WhyAug 3 2024, 7:30 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rK5f05cc674ae6: Make encrypted videos playable.

tusooa mentioned this in T119: Refactor video event type.Oct 9 2024, 6:53 PM

Revision Contents
Changeset List

Path

Size

Packages

src/

contents/

ui/

event-types/

Video.qml

15 lines

O1: the Kazv Project

Diff 381

View Options

src/contents/ui/event-types/Video.qml

Make encrypted videos playableClosedPublicActions