This add a confirm overlay for event deletion.
Type: add
Details
Details
- Reviewers
tusooa - Group Reviewers
O1: the Kazv Project - Maniphest Tasks
- T83: Confirm message deletion
- Commits
- rK99dfb7d74e57: Add confirm popup for delete event
Delete an event, verify that the confirm overlay appears.
Diff Detail
Diff Detail
- Repository
- rK kazv
- Branch
- confirm-deletion
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 238 Build 464: GitLab CI for kazv Build 463: arc lint + arc unit
Event Timeline
Comment Actions
Please add a changelog type to the summary, using the following format:
Type: (add|remove|skip|security|fix)
Comment Actions
We should also add a prompt for the user to optionally enter a reason for the deletion.
| src/contents/ui/Bubble.qml | ||
|---|---|---|
| 57–67 | use a Component for it. Instantiating OverlaySheets are expensive, so you should only instantiate it on demand. See the other popup for an example. | |
| src/l10n/cmn-Hans/100-ui.ftl | ||
| 343 | ||
| src/l10n/en/100-ui.ftl | ||
| 371 | ||
| src/tests/quick-tests/tst_EventView.qml | ||
| 505 | the property to test is now opened. | |
| src/contents/ui/Bubble.qml | ||
|---|---|---|
| 57–67 | Well, I think we'd better display the content of the event in the popup... See https://iron.lily-is.land/D131 for an example. | |
Comment Actions
- Use component for delete event confirm popup
- Add event content for delete event confirm popup
- Fix test
| src/contents/ui/RoomTimelineView.qml | ||
|---|---|---|
| 129–143 | Don't accept an eventView as the property because it can be destroyed at any time, or to refer to another event. Pass the event id directly, and use the EventView inside the overlay to redact it. | |
| src/contents/ui/RoomTimelineView.qml | ||
|---|---|---|
| 128–146 | test this logic | |
| src/contents/ui/RoomTimelineView.qml | ||
|---|---|---|
| 131 | Index is NOT reliable. It can change when new messages come in. Only use event id and txn id, which are invariant. | |
| src/contents/ui/RoomTimelineView.qml | ||
|---|---|---|
| 131 | This is exactly the same reason why I told you not to pass an EventView: because the EventView depends on the index. | |
| src/tests/quick-tests/tst_RoomTimelineView.qml | ||
|---|---|---|
| 200–202 | but deleting local echo can't fail.... | |
| src/tests/quick-tests/tst_RoomTimelineView.qml | ||
|---|---|---|
| 200–202 |
my mistake. | |