Page MenuHomePhorge
Differential D109

Fix local echoes being displayed as selected
ClosedPublic
Actions

Authored by tusooa on Jul 8 2024, 3:02 PM.
Tags
None
Referenced Files
F67165540: D109.1776369283.diff
Wed, Apr 15, 12:54 PM
F67159027: D109.1776368404.diff
Wed, Apr 15, 12:40 PM
F67158450: D109.1776368330.diff
Wed, Apr 15, 12:38 PM
F67158217: D109.1776368300.diff
Wed, Apr 15, 12:38 PM
F67155581: D109.1776367992.diff
Wed, Apr 15, 12:33 PM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rKedac19aa57d7: Fix local echoes being displayed as selected
Summary

Local echoes do not have event ids, so they are incorrectly marked as selected when selectedEventId is empty. This fixes the problem.

Type: fix

Test Plan

Send a message. Verify that it is not shown as selected when being sent.

Diff Detail

Repository
rK kazv
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 156
Build 301: GitLab CI for kazv
Build 300: arc lint + arc unit

Revision Contents
Changeset List

PathSizePackages
src/
contents/
ui/
2 linesO1: the Kazv Project
tests/
quick-tests/
92 linesO1: the Kazv Project

Diff 266

View Options

src/contents/ui/RoomTimelineView.qml

Loading...
View Options

src/tests/quick-tests/tst_RoomTimelineView.qml

Loading...