Page MenuHomePhorge
Differential D293

Fix process response without json body for GetVersionsAction
ClosedPublic
Actions

Authored by nannanko on Wed, Mar 18, 7:31 AM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Commits
rLe70f5822bcc9: Fix process response without json body for GetVersionsAction
Summary

Kazv::processResponse(ClientModel m, GetVersionsResponse r) cannot process response without json body, this diff fixed it.

Type: fix

Test Plan

Verify unit tests pass.

Diff Detail

Repository
rL libkazv
Branch
nannanko/get-version-process-response
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 569
Build 1120: Invoke BuildbotBuildbot build #1381
Build 1119: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
0 msCoverage (build:coverage)

https://b.lily-is.land/#/builders/42/builds/36

Event Timeline

nannanko created this revision.Wed, Mar 18, 7:31 AM
Owners added a reviewer: O1: the Kazv Project.Wed, Mar 18, 7:31 AM
tusooa published this revision for review.Wed, Mar 18, 7:37 AM
tusooa added inline comments.
src/client/actions/auth.cpp
164–166

You don't need to create a new lambda for this. failWithResponse(r) already meets the requirement of an effect.

tusooa requested changes to this revision.Wed, Mar 18, 7:37 AM
This revision now requires changes to proceed.Wed, Mar 18, 7:37 AM
Harbormaster failed remote builds in B568: Diff 882!Wed, Mar 18, 7:45 AM
nannanko updated this revision to Diff 884.Wed, Mar 18, 9:01 AM

Use failWithResponse(r) instead of lambda

nannanko marked an inline comment as done.Wed, Mar 18, 9:01 AM
Harbormaster failed remote builds in B569: Diff 884!Wed, Mar 18, 9:15 AM
tusooa accepted this revision.Thu, Mar 19, 8:00 PM

the test failure is not the fault of this diff. the coverage job did pass, the failing is because of lilybuild.

This revision is now accepted and ready to land.Thu, Mar 19, 8:00 PM
This revision was landed with ongoing or failed builds.Sat, Mar 21, 6:57 AM
Closed by commit rLe70f5822bcc9: Fix process response without json body for GetVersionsAction. · Explain Why
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rLe70f5822bcc9: Fix process response without json body for GetVersionsAction.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
client/
actions/
16 lines52%
Loading...
O1: the Kazv Project
tests/
client/
10 lines--O1: the Kazv Project

Diff 884

View Options

src/client/actions/auth.cpp

Loading...
View Options

src/tests/client/get-versions-test.cpp

Loading...