Page MenuHomePhorge
Differential D293

Fix process response without json body for GetVersionsAction
AcceptedPublic
Actions

Authored by nannanko on Wed, Mar 18, 7:31 AM.
Tags
None
Referenced Files
F49863651: D293.1774096460.diff
Fri, Mar 20, 5:34 AM
F49855988: D293.1774094904.diff
Fri, Mar 20, 5:08 AM
F49855818: D293.1774094871.diff
Fri, Mar 20, 5:07 AM
F49844669: D293.1774092637.diff
Fri, Mar 20, 4:30 AM
F49648153: D293.1774053310.diff
Thu, Mar 19, 5:35 PM
F49624455: D293.1774048597.diff
Thu, Mar 19, 4:16 PM
Subscribers
None

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Summary

Kazv::processResponse(ClientModel m, GetVersionsResponse r) cannot process response without json body, this diff fixed it.

Type: fix

Test Plan

Verify unit tests pass.

Diff Detail

Repository
rL libkazv
Branch
nannanko/get-version-process-response
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 568
Build 1118: Invoke BuildbotBuildbot build #1376
Build 1117: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
0 msCoverage (build:coverage)

https://b.lily-is.land/#/builders/42/builds/35

Event Timeline

nannanko created this revision.Wed, Mar 18, 7:31 AM
Owners added a reviewer: O1: the Kazv Project.Wed, Mar 18, 7:31 AM
tusooa published this revision for review.Wed, Mar 18, 7:37 AM
tusooa added inline comments.
src/client/actions/auth.cpp
164–166

You don't need to create a new lambda for this. failWithResponse(r) already meets the requirement of an effect.

tusooa requested changes to this revision.Wed, Mar 18, 7:37 AM
This revision now requires changes to proceed.Wed, Mar 18, 7:37 AM
Harbormaster failed remote builds in B568: Diff 882!Wed, Mar 18, 7:45 AM
nannanko updated this revision to Diff 884.Wed, Mar 18, 9:01 AM

Use failWithResponse(r) instead of lambda

nannanko marked an inline comment as done.Wed, Mar 18, 9:01 AM
Harbormaster failed remote builds in B569: Diff 884!Wed, Mar 18, 9:15 AM
tusooa accepted this revision.Thu, Mar 19, 8:00 PM

the test failure is not the fault of this diff. the coverage job did pass, the failing is because of lilybuild.

This revision is now accepted and ready to land.Thu, Mar 19, 8:00 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
client/
actions/
18 lines52%
Loading...
O1: the Kazv Project
tests/
client/
10 lines--O1: the Kazv Project

Diff 882

View Options

src/client/actions/auth.cpp

Loading...
View Options

src/tests/client/get-versions-test.cpp

Loading...