Details

Reviewers

None

Group Reviewers

O1: the Kazv Project

Maniphest Tasks

T156: SAS verification

Summary

This is the part 1 of https://iron.lily-is.land/T156 . It implements a sans-io SAS verification process.

Type: add

Test Plan

To be tested together with later diffs of verification.

Diff Detail

Repository

rL libkazv

Branch

tusooa/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 555
Build 1092: Invoke Buildbot	Buildbot build #1260
Build 1091: arc lint + arc unit

Event Timeline

tusooa created this revision.Sun, Mar 1, 6:29 PM

Owners added a reviewer: O1: the Kazv Project.Sun, Mar 1, 6:29 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sun, Mar 1, 7:02 PM

Harbormaster failed remote builds in B553: Diff 862!

add a little error handling

It's not yet complete. We need more error handling.

tusooa added inline comments.Mon, Mar 2, 4:07 PM

src/crypto/verification-process.cpp
52	should have a way to start an outgoing request
65	need to validate the format of events
147	missing `userCancel()`
155	should also have `userDenyMatch()`
src/crypto/verification-process.hpp
102	not yet implemented

tusooa added a task: T156: SAS verification.Mon, Mar 2, 4:10 PM

Harbormaster completed remote builds in B555: Diff 865.Mon, Mar 2, 4:15 PM

tusooa requested review of this revision.Mon, Mar 2, 4:15 PM

Add some validations

Harbormaster completed remote builds in B556: Diff 866.Tue, Mar 3, 8:39 PM

more error handling

Harbormaster completed remote builds in B560: Diff 872.Wed, Mar 11, 10:43 PM

Move state into VerificationProcess

Harbormaster completed remote builds in B561: Diff 873.Thu, Mar 12, 12:46 PM

mmore tests and error handling

Harbormaster completed remote builds in B563: Diff 875.Fri, Mar 13, 2:09 PM

What if one party sends a bad key event? Should test that it correctly sends a cancel event of invalid_message

better tests and error handling

Harbormaster completed remote builds in B564: Diff 876.Fri, Mar 13, 9:02 PM

Move display codes and pending events into VerificationProcess

Harbormaster completed remote builds in B567: Diff 880.Sat, Mar 14, 3:56 PM

Only keep codes into model, leave pending events as return value

Harbormaster completed remote builds in B570: Diff 885.Thu, Mar 19, 4:40 PM

Knowing whether an outgoing event is sent is of no use. It seems that we should add the outgoing events right away.

Automatically add outgoing events returned from the processing

Harbormaster completed remote builds in B575: Diff 891.Mon, Mar 23, 5:21 PM

tusooa added inline comments.Mon, Mar 23, 9:13 PM

src/crypto/verification-process.cpp
300–343	These user-interactive functions should guard against multiple calls. Calling them under bad timing (e.g. user clicking the button multiple times) should be no-op.

tusooa added a child revision: D294: Add verification tracker.Mon, Mar 23, 9:25 PM

Implement single SAS verification process
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 865

src/crypto/CMakeLists.txt

src/crypto/sas-desc.hpp

src/crypto/sas-desc.cpp

src/crypto/verification-process.hpp

src/crypto/verification-process.cpp

src/tests/CMakeLists.txt

src/tests/crypto/verification-process-test.cpp

Implement single SAS verification processNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 865

src/crypto/CMakeLists.txt

src/crypto/sas-desc.hpp

src/crypto/sas-desc.cpp

src/crypto/verification-process.hpp

src/crypto/verification-process.cpp

src/tests/CMakeLists.txt

src/tests/crypto/verification-process-test.cpp

Implement single SAS verification process
Needs ReviewPublic
Actions

Revision Contents
Changeset List