Paths

Table of Contentst

Differential D289

Implement single SAS verification process
Needs ReviewPublic
Actions

Authored by tusooa on Sun, Mar 1, 6:29 PM.

Details

Reviewers

None

Group Reviewers

O1: the Kazv Project

Maniphest Tasks

T156: SAS verification

Summary

This is the part 1 of https://iron.lily-is.land/T156 . It implements a sans-io SAS verification process.

Type: add

Test Plan

To be tested together with later diffs of verification.

Diff Detail

Repository

rL libkazv

Branch

tusooa/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 560
Build 1102: Invoke Buildbot	Buildbot build #1312
Build 1101: arc lint + arc unit

Event Timeline

tusooa created this revision.Sun, Mar 1, 6:29 PM

Owners added a reviewer: O1: the Kazv Project.Sun, Mar 1, 6:29 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sun, Mar 1, 7:02 PM

Harbormaster failed remote builds in B553: Diff 862!

add a little error handling

It's not yet complete. We need more error handling.

tusooa added inline comments.Mon, Mar 2, 4:07 PM

src/crypto/verification-process.cpp
53	should have a way to start an outgoing request
66	need to validate the format of events
148	missing `userCancel()`
156	should also have `userDenyMatch()`
src/crypto/verification-process.hpp
103	not yet implemented

tusooa added a task: T156: SAS verification.Mon, Mar 2, 4:10 PM

Harbormaster completed remote builds in B555: Diff 865.Mon, Mar 2, 4:15 PM

tusooa requested review of this revision.Mon, Mar 2, 4:15 PM

Add some validations

Harbormaster completed remote builds in B556: Diff 866.Tue, Mar 3, 8:39 PM

more error handling

Harbormaster completed remote builds in B560: Diff 872.Wed, Mar 11, 10:43 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

crypto/

2 lines

114 lines

225 lines

88%

O1: the Kazv Project

verification-process.hpp

248 lines

77%

O1: the Kazv Project

verification-process.cpp

541 lines

85%

O1: the Kazv Project

verification-utils.hpp

31 lines

O1: the Kazv Project

verification-utils.cpp

48 lines

O1: the Kazv Project

tests/

CMakeLists.txt

1 line

O1: the Kazv Project

crypto/

verification-process-test.cpp

220 lines

O1: the Kazv Project

Diff 872

View Options

src/crypto/CMakeLists.txt

View Options

src/crypto/sas-desc.hpp

View Options

src/crypto/sas-desc.cpp

View Options

src/crypto/verification-process.hpp

View Options

src/crypto/verification-process.cpp

View Options

src/crypto/verification-utils.hpp

View Options

src/crypto/verification-utils.cpp

View Options

src/tests/CMakeLists.txt

View Options

src/tests/crypto/verification-process-test.cpp

Implement single SAS verification processNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 872

src/crypto/CMakeLists.txt

src/crypto/sas-desc.hpp

src/crypto/sas-desc.cpp

src/crypto/verification-process.hpp

src/crypto/verification-process.cpp

src/crypto/verification-utils.hpp

src/crypto/verification-utils.cpp

src/tests/CMakeLists.txt

src/tests/crypto/verification-process-test.cpp

Implement single SAS verification process
Needs ReviewPublic
Actions

Revision Contents
Changeset List