Differential D274

Change type of buffer to string_view in WriteCallback
ClosedPublic
Actions

Authored by Yucheng on Sat, Jan 24, 6:57 PM.

Details

Reviewers

tusooa

Group Reviewers

O1: the Kazv Project

Commits

rL790ada816687: Change type of buffer to string_view in WriteCallback

Summary

Solve compilation error for newer version of cpr

Type: fix

Test Plan

Test whether the code can compile successfully on cpr version 1.14.1

Diff Detail

Repository

rL libkazv

Branch

yucheng

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 532
Build 1046: Invoke Buildbot	Buildbot build #1055 · Requires approval
Build 1045: arc lint + arc unit

Event Timeline

Yucheng created this revision.Sat, Jan 24, 6:57 PM

Owners added a reviewer: O1: the Kazv Project.Sat, Jan 24, 6:57 PM

Harbormaster completed remote builds in B532: Diff 824.Sat, Jan 24, 7:18 PM

Yucheng requested review of this revision.Sat, Jan 24, 7:18 PM

Reserve the original overload for std::string

Yucheng edited the test plan for this revision. (Show Details)Sat, Jan 24, 7:49 PM

Harbormaster completed remote builds in B533: Diff 826.Sat, Jan 24, 8:00 PM

tusooa accepted this revision.Sat, Jan 24, 8:11 PM

This revision is now accepted and ready to land.Sat, Jan 24, 8:11 PM

Closed by commit rL790ada816687: Change type of buffer to string_view in WriteCallback. · Explain WhySat, Jan 24, 9:31 PM

This revision was automatically updated to reflect the committed changes.

Yucheng added a commit: rL790ada816687: Change type of buffer to string_view in WriteCallback.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

job/

cprjobhandler.cpp

4 lines

29%

O1: the Kazv Project

Diff 824

View Options

Change type of buffer to string_view in WriteCallbackClosedPublicActions