Page MenuHomePhorge
Differential D250

Check rules when executing step
ClosedPublic
Actions

Authored by tusooa on Fri, Dec 5, 9:07 AM.

Details

Reviewers
None
Group Reviewers
O2: lilybuild
Commits
rBc7d49a9424c1: Check rules when executing step
Summary

We will now check rules:if and will not execute the step if it is not meant to be run.

Type: add

Test Plan

Test it on a repo with a pipeline containing rules:if and verify it behaves as intended.

Diff Detail

Repository
rB lilybuild
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 479
Build 941: Invoke BuildbotBuildbot build #439
Build 940: arc lint + arc unit

Event Timeline

tusooa created this revision.Fri, Dec 5, 9:07 AM
Owners added a reviewer: O2: lilybuild.Fri, Dec 5, 9:07 AM
Harbormaster completed remote builds in B479: Diff 746.Fri, Dec 5, 9:09 AM
tusooa requested review of this revision.Fri, Dec 5, 9:09 AM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Dec 5, 9:58 AM
Closed by commit rBc7d49a9424c1: Check rules when executing step. · Explain Why
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rBc7d49a9424c1: Check rules when executing step.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
lilybuild/
lilybuild/
51 lines--O2: lilybuild
ci_syntax/
5 lines98%
Loading...
O2: lilybuild
1 line--O2: lilybuild
tests/
ci_syntax/
4 lines--O2: lilybuild
res/
15 lines--O2: lilybuild

Diff 746

View Options

lilybuild/lilybuild/ci_steps.py

Loading...
View Options

lilybuild/lilybuild/ci_syntax/ci_file.py

Loading...
View Options

lilybuild/lilybuild/config.py

Loading...
View Options

lilybuild/lilybuild/tests/ci_syntax/ci_file_test.py

Loading...
View Options

lilybuild/lilybuild/tests/ci_syntax/res/variables.yaml

Loading...