Page MenuHomePhorge

Display edited version of events
ClosedPublic

Authored by tusooa on Apr 24 2024, 8:26 PM.
Tags
None
Referenced Files
F8647236: D5.1761674512.diff
Mon, Oct 27, 11:01 AM
F8647233: D5.1761674508.diff
Mon, Oct 27, 11:01 AM
F8647232: D5.1761674501.diff
Mon, Oct 27, 11:01 AM
F8645973: D5.1761657557.diff
Mon, Oct 27, 6:19 AM
F8645586: D5.1761651457.diff
Mon, Oct 27, 4:37 AM
F8645585: D5.1761651442.diff
Mon, Oct 27, 4:37 AM
F8642469: D5.1761625566.diff
Sun, Oct 26, 9:26 PM
F8642467: D5.1761625554.diff
Sun, Oct 26, 9:25 PM
Subscribers
None

Details

Summary

Display edited version of events

Type: add

Test Plan
  • Open kazv
  • Send a message
  • Edit the message from another client
  • Observe that the message is shown as edited
  • Observe that the standalone edit is not shown in the timeline

Diff Detail

Repository
rK kazv
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 44
Build 77: GitLab CI for kazv
Build 76: arc lint + arc unit

Event Timeline

tusooa created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2024, 12:55 PM
This revision was automatically updated to reflect the committed changes.

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

This was lost when I pushed my local dev branch to lily. Reopening. @nannanko

@nannanko also it looks like that this would fix the test failure on kazv|servant branch because of the following:

// ignore edits of other events
if (e.relationType === 'm.replace') {
  return 'ignore';
}
This revision is now accepted and ready to land.May 19 2024, 1:17 AM
This revision was automatically updated to reflect the committed changes.