Page MenuHomePhorge
Differential D209

Fix crash when a room hero's display name is not a string
Changes PlannedPublicDraft
Actions

Authored by tusooa on Feb 14 2025, 7:28 PM.
Tags
None
Referenced Files
F2595877: D209.1751280015.diff
Sun, Jun 29, 3:40 AM
F2595860: D209.1751279932.diff
Sun, Jun 29, 3:38 AM
F2595751: D209.1751279092.diff
Sun, Jun 29, 3:24 AM
F2595699: D209.1751277114.diff
Sun, Jun 29, 2:51 AM
F2595525: D209.1751268623.diff
Sun, Jun 29, 12:30 AM
Subscribers
None

Details

Reviewers
None
Group Reviewers
O1: the Kazv Project
Summary

The xform() in Room::heroDisplayNames() did not correctly verify the name is convertible to a string. This adds that check.

Type: fix

Test Plan

Verify unit tests pass.

Diff Detail

Repository
rL libkazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 336
Build 655: GitLab CI for libkazv
Build 654: arc lint + arc unit

Event Timeline

tusooa created this revision.Feb 14 2025, 7:28 PM
Owners added a reviewer: O1: the Kazv Project.Feb 14 2025, 7:28 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jun 18, 4:47 PM
Harbormaster failed remote builds in B336: Diff 556!

Revision Contents
Changeset List

PathSizePackages
src/
client/
room/
2 linesO1: the Kazv Project
tests/
client/
28 linesO1: the Kazv Project

Diff 556

View Options

src/client/room/room.cpp

Loading...
View Options

src/tests/client/room-test.cpp

Loading...