Page MenuHomePhorge

Add indicator for tombstoned room
ClosedPublic

Authored by nannanko on Nov 2 2024, 8:20 PM.
Tags
None
Referenced Files
F1035869: D197.1747138874.diff
Mon, May 12, 5:21 AM
F1032232: D197.1747122773.diff
Mon, May 12, 12:52 AM
F1032227: D197.1747122758.diff
Mon, May 12, 12:52 AM
F1028002: D197.1747093952.diff
Sun, May 11, 4:52 PM
Subscribers
None

Details

Summary

Add indicator for tombstoned room.

Type: add

Test Plan

Verify unit tests passes.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa requested changes to this revision.Nov 2 2024, 9:19 PM
tusooa added inline comments.
src/matrix-room.cpp
77–80

We can use string literals (""s https://en.cppreference.com/w/cpp/string/basic_string/operator%22%22s ) to make it more concise.

.make() should be unnecessary, and you can use .map() instead of .xform(zug::map()).

This revision now requires changes to proceed.Nov 2 2024, 9:19 PM
tusooa requested changes to this revision.Nov 3 2024, 7:08 AM
tusooa added inline comments.
src/matrix-room.cpp
33

Include std headers right after <kazv-defs.hpp>

This revision now requires changes to proceed.Nov 3 2024, 7:08 AM

Include std headers right after <kazv-defs.hpp>

This revision is now accepted and ready to land.Nov 9 2024, 3:05 PM
This revision was landed with ongoing or failed builds.Nov 9 2024, 6:01 PM
This revision was automatically updated to reflect the committed changes.