Page MenuHomePhorge

Add indicator for tombstoned room
ClosedPublic

Authored by nannanko on Nov 2 2024, 8:20 PM.
Tags
None
Referenced Files
F3154201: D197.1753329933.diff
Tue, Jul 22, 9:05 PM
F3152316: D197.1753323814.diff
Tue, Jul 22, 7:23 PM
F3152239: D197.1753323649.diff
Tue, Jul 22, 7:20 PM
F3147596: D197.1753310628.diff
Tue, Jul 22, 3:43 PM
F3146382: D197.1753307899.diff
Tue, Jul 22, 2:58 PM
F3139942: D197.1753283712.diff
Tue, Jul 22, 8:15 AM
F3133637: D197.1753264266.diff
Tue, Jul 22, 2:51 AM
Subscribers
None

Details

Summary

Add indicator for tombstoned room.

Type: add

Test Plan

Verify unit tests passes.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa requested changes to this revision.Nov 2 2024, 9:19 PM
tusooa added inline comments.
src/matrix-room.cpp
77–80

We can use string literals (""s https://en.cppreference.com/w/cpp/string/basic_string/operator%22%22s ) to make it more concise.

.make() should be unnecessary, and you can use .map() instead of .xform(zug::map()).

This revision now requires changes to proceed.Nov 2 2024, 9:19 PM
tusooa requested changes to this revision.Nov 3 2024, 7:08 AM
tusooa added inline comments.
src/matrix-room.cpp
33

Include std headers right after <kazv-defs.hpp>

This revision now requires changes to proceed.Nov 3 2024, 7:08 AM

Include std headers right after <kazv-defs.hpp>

This revision is now accepted and ready to land.Nov 9 2024, 3:05 PM
This revision was landed with ongoing or failed builds.Nov 9 2024, 6:01 PM
This revision was automatically updated to reflect the committed changes.