Page MenuHomePhorge

Add indicator for tombstoned room
ClosedPublic

Authored by nannanko on Nov 2 2024, 8:20 PM.
Tags
None
Referenced Files
F7778112: D197.1758799302.diff
Wed, Sep 24, 4:21 AM
F7775679: D197.1758787523.diff
Wed, Sep 24, 1:05 AM
F7771922: D197.1758748779.diff
Tue, Sep 23, 2:19 PM
F7771890: D197.1758746957.diff
Tue, Sep 23, 1:49 PM
F7771521: D197.1758726252.diff
Tue, Sep 23, 8:04 AM
Subscribers
None

Details

Summary

Add indicator for tombstoned room.

Type: add

Test Plan

Verify unit tests passes.

Diff Detail

Repository
rK kazv
Branch
nannanko/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 315
Build 618: GitLab CI for kazv
Build 617: arc lint + arc unit

Event Timeline

tusooa requested changes to this revision.Nov 2 2024, 9:19 PM
tusooa added inline comments.
src/matrix-room.cpp
77–80

We can use string literals (""s https://en.cppreference.com/w/cpp/string/basic_string/operator%22%22s ) to make it more concise.

.make() should be unnecessary, and you can use .map() instead of .xform(zug::map()).

This revision now requires changes to proceed.Nov 2 2024, 9:19 PM
tusooa requested changes to this revision.Nov 3 2024, 7:08 AM
tusooa added inline comments.
src/matrix-room.cpp
31

Include std headers right after <kazv-defs.hpp>

This revision now requires changes to proceed.Nov 3 2024, 7:08 AM

Include std headers right after <kazv-defs.hpp>

This revision is now accepted and ready to land.Nov 9 2024, 3:05 PM
This revision was landed with ongoing or failed builds.Nov 9 2024, 6:01 PM
This revision was automatically updated to reflect the committed changes.