Page MenuHomePhorge

Add indicator for tombstoned room
ClosedPublic

Authored by nannanko on Sat, Nov 2, 8:20 PM.
Tags
None
Referenced Files
F110784: D197.1731683530.diff
Thu, Nov 14, 7:12 AM
F110755: D197.1731647436.diff
Wed, Nov 13, 9:10 PM
F110754: D197.1731646505.diff
Wed, Nov 13, 8:55 PM
F110741: D197.1731632342.diff
Wed, Nov 13, 4:59 PM
F110739: D197.1731630384.diff
Wed, Nov 13, 4:26 PM
Subscribers
None

Details

Summary

Add indicator for tombstoned room.

Type: add

Test Plan

Verify unit tests passes.

Diff Detail

Repository
rK kazv
Branch
nannanko/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 319
Build 626: GitLab CI for kazv
Build 625: arc lint + arc unit

Event Timeline

tusooa requested changes to this revision.Sat, Nov 2, 9:19 PM
tusooa added inline comments.
src/matrix-room.cpp
77–80

We can use string literals (""s https://en.cppreference.com/w/cpp/string/basic_string/operator%22%22s ) to make it more concise.

.make() should be unnecessary, and you can use .map() instead of .xform(zug::map()).

This revision now requires changes to proceed.Sat, Nov 2, 9:19 PM
tusooa requested changes to this revision.Sun, Nov 3, 7:08 AM
tusooa added inline comments.
src/matrix-room.cpp
33

Include std headers right after <kazv-defs.hpp>

This revision now requires changes to proceed.Sun, Nov 3, 7:08 AM

Include std headers right after <kazv-defs.hpp>

This revision is now accepted and ready to land.Sat, Nov 9, 3:05 PM
This revision was landed with ongoing or failed builds.Sat, Nov 9, 6:01 PM
This revision was automatically updated to reflect the committed changes.