Page MenuHomePhorge

Add indicator for tombstoned room
ClosedPublic

Authored by nannanko on Sat, Nov 2, 8:20 PM.
Tags
None
Referenced Files
F112300: D197.1732290859.diff
Thu, Nov 21, 7:54 AM
F112278: D197.1732287674.diff
Thu, Nov 21, 7:01 AM
F112269: D197.1732286602.diff
Thu, Nov 21, 6:43 AM
Subscribers
None

Details

Summary

Add indicator for tombstoned room.

Type: add

Test Plan

Verify unit tests passes.

Diff Detail

Repository
rK kazv
Branch
nannanko/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 313
Build 614: GitLab CI for kazv
Build 613: arc lint + arc unit

Event Timeline

tusooa requested changes to this revision.Sat, Nov 2, 9:19 PM
tusooa added inline comments.
src/matrix-room.cpp
74–77

We can use string literals (""s https://en.cppreference.com/w/cpp/string/basic_string/operator%22%22s ) to make it more concise.

.make() should be unnecessary, and you can use .map() instead of .xform(zug::map()).

This revision now requires changes to proceed.Sat, Nov 2, 9:19 PM
tusooa requested changes to this revision.Sun, Nov 3, 7:08 AM
tusooa added inline comments.
src/matrix-room.cpp
31

Include std headers right after <kazv-defs.hpp>

This revision now requires changes to proceed.Sun, Nov 3, 7:08 AM

Include std headers right after <kazv-defs.hpp>

This revision is now accepted and ready to land.Sat, Nov 9, 3:05 PM
This revision was landed with ongoing or failed builds.Sat, Nov 9, 6:01 PM
This revision was automatically updated to reflect the committed changes.