KazvFile and KazvSaveFile are only used within their job. Setting parent is simpler and less buggy than using QSharedPointer.
Type: skip
Differential D178
Set parent of KazvFile and KazvSaveFile, instead of QSharedPointer nannanko on Aug 24 2024, 7:13 AM. Authored by Tags None Referenced Files None Subscribers None
Details
KazvFile and KazvSaveFile are only used within their job. Setting parent is simpler and less buggy than using QSharedPointer. Type: skip N/A
Diff Detail
Event TimelineComment Actions Actually nothing. It's just that I think setting QObject parent is simpler than using a smart pointer. If you don’t like this change, forget it, because I haven’t found any related BUG for the time being. Comment Actions I don't see how it's simpler. parenting and shared pointers provide different types of guarantees. |