Set parent of KazvFile and KazvSaveFile, instead of QSharedPointer
AbandonedPublic
Actions

Authored by nannanko on Sat, Aug 24, 7:13 AM.

Details

Reviewers

Group Reviewers

Summary

KazvFile and KazvSaveFile are only used within their job. Setting parent is simpler and less buggy than using QSharedPointer.

Type: skip

Test Plan

N/A

Diff Detail

Repository

rK kazv

Branch

nannanko/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 281
Build 550: GitLab CI for kazv
Build 549: arc lint + arc unit

Event Timeline

nannanko created this revision.Sat, Aug 24, 7:13 AM

Owners added a reviewer: O1: the Kazv Project.Sat, Aug 24, 7:13 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Aug 24, 7:29 AM

Harbormaster failed remote builds in B281: Diff 468!

Harbormaster completed remote builds in B281: Diff 468.Sat, Aug 24, 6:25 PM

nannanko requested review of this revision.Sat, Aug 24, 6:25 PM

How is it "less buggy"? What bug does it fix?

This revision now requires changes to proceed.Tue, Aug 27, 7:05 PM

In D178#3268, @tusooa wrote:

How is it "less buggy"? What bug does it fix?

Actually nothing. It's just that I think setting QObject parent is simpler than using a smart pointer. If you don’t like this change, forget it, because I haven’t found any related BUG for the time being.

In D178#3283, @nannanko wrote:

In D178#3268, @tusooa wrote:

How is it "less buggy"? What bug does it fix?

Actually nothing. It's just that I think setting QObject parent is simpler than using a smart pointer. If you don’t like this change, forget it, because I haven’t found any related BUG for the time being.