This adds a function in Room to get a local echo in the room by its txn id.
Type: add
Details
Details
- Reviewers
tusooa - Group Reviewers
O1: the Kazv Project - Commits
- rLfb328512137c: Add Room::localEcho and related test
Verify tests pass.
Diff Detail
Diff Detail
- Repository
- rL libkazv
- Branch
- nannanko/stacked
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 240 Build 468: GitLab CI for libkazv Build 467: arc lint + arc unit
Event Timeline
Comment Actions
Please add a changelog type to the summary, using the following format:
Type: (add|remove|skip|security|fix)
Comment Actions
add a test to verify it does not crash when the txn id is not found.
| src/client/room/room.cpp | ||
|---|---|---|
| 109 | you must handle the case where find_if returns localEchoes.end(), which is an invalid iterator. this MAY WELL happen if, in the process of cancelling, the message has already been sent. your current implementation will cause undefined behaviour due to dereferencing the past-the-end iterator, which is invalid. | |