kazv can't upload file for reply, this enable it.
Type: add
Details
Details
- Reviewers
tusooa - Group Reviewers
O1: the Kazv Project - Maniphest Tasks
- T82: Support uploading file when replying to another message
- Commits
- rK7e36b4584a66: Enable upload file for reply
Click reply, and upload file, verify that a reply event was sent
Diff Detail
Diff Detail
- Repository
- rK kazv
- Branch
- upload-file-reply
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 221 Build 431: GitLab CI for kazv Build 430: arc lint + arc unit
Event Timeline
Comment Actions
Please add a changelog type to the summary, using the following format:
Type: (add|remove|skip|security|fix)
| src/contents/ui/SendMessageBox.qml | ||
|---|---|---|
| 69–218 |
It seems that my editor automatically removed the spaces from these lines, do I need to change it to the original? | |
| src/contents/ui/SendMessageBox.qml | ||
|---|---|---|
| 69–218 | ok i saw that it's not a removed newline but a removed whitespace-only line. i'll add a lint rule to disallow whitespace-only lines. https://iron.lily-is.land/D146 | |
| src/contents/ui/SendMessageBox.qml | ||
|---|---|---|
| 352–357 | add a test to verify it does call startNewUploadJob with the intended parameters | |
| src/tests/quick-tests/test-helpers/KazvIOManagerMock.qml | ||
|---|---|---|
| 11–22 ↗ | (On Diff #390) | Use mockHelper properly |
| src/tests/quick-tests/tst_SendMessageBox.qml | ||
| 64 ↗ | (On Diff #390) | Use a safe url here |
| 245–255 ↗ | (On Diff #390) | Take a look at CreateRoomTest to use a transformation (in MockHelper.qml), and deepEqual() in test-helpers.js to ease your comparison |
| src/tests/quick-tests/test-helpers/KazvIOManagerMock.qml | ||
|---|---|---|
| 11 ↗ | (On Diff #395) | unrelated changes |
| src/matrix-room.cpp | ||
|---|---|---|
| 298–299 | ||
Comment Actions
The unit test failure seems to be related to @apr3vau 's changes, not yours. Land this.